Prevent disabling/enabling mod loaders #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the changes, mod loaders could be disabled, but in most cases it didn't really do anything. Disabling e.g. BepInEx and running the game modded still loaded the mods. Defining how each mod loader should be actually disabled isn't trivial, and the need to actually disable them is low, as user can always just choose to run the vanilla game. Therefore it was decided that just hiding the disable option for package loaders was the best approach. This adds 0-0.1ms rendering delay for each mod. While not ideal, it doesn't affect even the bigger profiles too badly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the changes, mod loaders could be disabled, but in most cases it didn't really do anything. Disabling e.g. BepInEx and running the game modded still loaded the mods.
Defining how each mod loader should be actually disabled isn't trivial, and the need to actually disable them is low, as user can always just choose to run the vanilla game. Therefore it was decided that just hiding the disable option for package loaders was the best approach.
This adds 0-0.1ms rendering delay for each mod. While not ideal, it doesn't affect even the bigger profiles too badly.