New python interface with documentation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification to interface: - new methods `intersect`, `intersect_ISO`, `intersect_SAE`, `closestPoint`, `findST` - different return value in `closestPoint_ISO`, `closestPoint_SAE`, `findST_ISO`,`findST_SAE` - documentation for all methods in base curve class
- removed functions wrapped now in base curve - added documentation to all methods of biarc - getC0 becomes c0 - getC1 becomes c1
The copy method is now more pythonic, and returns a copy instead of copying from another object on self
Revision of BiarcList wrappers - removed new abstract methods included in BaseCurve - get methods as an alias: __getitem__ - numSegment is now numSegments - findST1 has a different return value - documentation for all the methods - copy is now pythonic (returns the copy instead of applying on current object)
refreshed wrapper for CircleArc class - added build method - copy method is more pythonic, and returns a copy instead of copying another target on the self instance - docs for all methods - ray renamed radius - removed abstract BaseClass methods
Full remake of the LineSegment and PolyLine interfaces - copy methods is more pythonic, returning a copy instead of copying onto current instance - added __getitem__ to polyline - documentation for all methods
Full remake of the interface for clothoids and clothoids list - added documentation to all methods - clothoidslist: new __getitem__, __len__, build_raw, push_back(ClothoidList), save and load methods - clothoidslist: numSegment is renamed numSegments
This commit introduces several improvements to classes: * G2libHeaders has a declaration for undef min/max on windows * BaseCurve: methods theta, kappa, X, Y, X_ISO, Y_ISO, tx, ty, theta_D, theta_DD, theta_DDD, evaluate, eval, evaluate_ISO, eval_ISO, eval_D, eval_DD, eval_DDD, closestPoint, findST have been expanded with vectorial interfaces * BiarcList: findST1 vectorial interface * CircleArc: empty constructor * ClothoidList: new method wrap_in_range, closest_segment, closestPointInRange (scalar and vectorial), closestPointInRange_ISO, closestPointInRange_SAE, closestPointInSRange (scalar and vectorial), closestPointInSRange_ISO, closestPointInSRange_SAE and vectorial findST1 introduced * LineSegment: empty constructor * PolyLine: new __len__ method In tests, usage reflects update in interface. New test, disabled test case 6 for which there is nofile available for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of the python interface with documentation for almost all methods.
Notable changes: