Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vis}[GCCcore/11.2.0] jbigkit v2.1 + add missing header file to older versions #14081

Merged

Conversation

SebastianAchilles
Copy link
Member

(created using eb --new-pr)

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Sep 30, 2021
@SebastianAchilles
Copy link
Member Author

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/f718084c440339d479e69a0a29a67ce0 for a full test report.

@SebastianAchilles
Copy link
Member Author

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=14081 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14081 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7014

Test results coming soon (I hope)...

- notification for comment with ID 931639914 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0c63e52a74357641d43459275df3306b for a full test report.

@smoors
Copy link
Contributor

smoors commented Oct 1, 2021

@SebastianAchilles there is an issue with all jbigkit-2.1installations, discovered while testing libtiff PR #14079.
LibTIFF does not pick up jbigkit because of a missing header file 'libjbig/jbig_ar.h', that is not copied to the installdir.

@smoors smoors added the bug fix label Oct 3, 2021
@smoors smoors changed the title {vis}[GCCcore/11.2.0] jbigkit v2.1 {vis}[GCCcore/11.2.0] jbigkit v2.1 + add missing header file to older versions Oct 3, 2021
@smoors smoors modified the milestones: 4.x, next release (4.5.0?) Oct 3, 2021
@smoors
Copy link
Contributor

smoors commented Oct 3, 2021

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=14081 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14081 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7031

Test results coming soon (I hope)...

- notification for comment with ID 933001665 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/cf437ae13e52b1ccd65f401aed37821a for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Oct 3, 2021

Going in, thanks @SebastianAchilles!

@smoors smoors merged commit 19563e4 into easybuilders:develop Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants