Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependencies for recent LibTIFF versions: XZ, jbigkit, zstd #14079

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Sep 30, 2021

(created using eb --new-pr)

@smoors smoors added the bug fix label Sep 30, 2021
@smoors smoors added this to the 4.x milestone Sep 30, 2021
@smoors
Copy link
Contributor Author

smoors commented Sep 30, 2021

@boegelbot: please test @ generoso

@akesandgren
Copy link
Contributor

@smoors note that at least LibTIFF 4.2.0 tries to find jbigkit too
This is the config_step summary for 4.2.0:

 Support for external codecs:
  ZLIB support:                       yes
  libdeflate support:                 no
  Pixar log-format algorithm:         yes
  JPEG support:                       yes
  Old JPEG support:                   yes
  JPEG 8/12 bit dual mode:            no
  ISO JBIG support:                   no
  LZMA2 support:                      no
  ZSTD support:                       no
  WEBP support:                       no

  C++ support:                        yes

  OpenGL support:                     no

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=14079 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14079 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7012

Test results coming soon (I hope)...

- notification for comment with ID 931330126 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/fcca00d5d213bacc9a3d2c3c5d7b500b for a full test report.

@smoors
Copy link
Contributor Author

smoors commented Sep 30, 2021

@akesandgren good point. should we add ZSTD too then?

@smoors
Copy link
Contributor Author

smoors commented Sep 30, 2021

in any case it would be good to explicitly disable the formats for deps that are not included, so they don't get picked up from the system.

@akesandgren
Copy link
Contributor

Yeah we should add it and explicitly disable stuff we're not adding deps for, if possible.

@SebastianAchilles
Copy link
Member

SebastianAchilles commented Sep 30, 2021

@easybuilders easybuilders deleted a comment from boegelbot Oct 3, 2021
@smoors smoors modified the milestones: 4.x, next release (4.5.0?) Oct 3, 2021
@smoors
Copy link
Contributor Author

smoors commented Oct 3, 2021

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=14079 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14079 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7032

Test results coming soon (I hope)...

- notification for comment with ID 933004374 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/ecadcb5ec1152ad5ad36adebd0680ef9 for a full test report.

@smoors
Copy link
Contributor Author

smoors commented Oct 3, 2021

with this PR and the fixes in PR #14081, the config looks now like this:

 Support for external codecs:
  ZLIB support:                       yes
  libdeflate support:                 no
  Pixar log-format algorithm:         yes
  JPEG support:                       yes
  Old JPEG support:                   yes
  JPEG 8/12 bit dual mode:            no
  ISO JBIG support:                   yes
  LZMA2 support:                      yes
  ZSTD support:                       yes
  WEBP support:                       no

  C++ support:                        yes

  OpenGL support:                     no

@lexming
Copy link
Contributor

lexming commented Oct 16, 2021

Test report by @lexming
SUCCESS
Build succeeded for 29 out of 29 (5 easyconfigs in total)
node305.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/c65f6d561f0dfe94b71eccaf432d3ae4 for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Oct 16, 2021

Going in, thanks @smoors !

@lexming lexming merged commit 6cf9412 into easybuilders:develop Oct 16, 2021
@boegel boegel changed the title add missing XZ dependency for recent LibTIFF versions add missing dependencies for recent LibTIFF versions: XZ, jbigkit, zstd Oct 27, 2021
@boegel boegel added the change label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants