Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link order in PETSc easyblock for SCOTCH >= 7.x #3069

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix link order in PETSc easyblock for SCOTCH >= 7.x #3069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions easybuild/easyblocks/p/petsc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,10 @@ def configure_step(self):
inc_spec = "-include=[%s]" % ','.join(scotch_inc)

# For some reason there is a v3 suffix added to libptscotchparmetis
# which is the reason for this new code.
req_scotch_libs = ['libesmumps.a', 'libptesmumps.a', 'libptscotch.a',
'libptscotcherr.a', 'libptscotchparmetisv3.a', 'libscotch.a',
'libscotcherr.a']
# which is the reason for this new code;
# note: order matters here, don't sort these alphabetically!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's much easier for human eyes! :p

lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... :)

req_scotch_libs = ['libptesmumps.a', 'libptscotchparmetisv3.a', 'libptscotch.a',
'libptscotcherr.a', 'libesmumps.a', 'libscotch.a', 'libscotcherr.a']
scotch_libs = [os.path.join(scotch, "lib", x) for x in req_scotch_libs]
lib_spec = "-lib=[%s]" % ','.join(scotch_libs)
self.cfg.update('configopts', ' '.join([withdep + spec for spec in ['=1', inc_spec, lib_spec]]))
Expand Down
Loading