-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix link order in PETSc easyblock for SCOTCH >= 7.x #3069
fix link order in PETSc easyblock for SCOTCH >= 7.x #3069
Conversation
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1879230009 processed Message to humans: this is just bookkeeping information for me, |
'libptscotcherr.a', 'libptscotchparmetisv3.a', 'libscotch.a', | ||
'libscotcherr.a'] | ||
# which is the reason for this new code; | ||
# note: order matters here, don't sort these alphabetically! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it's much easier for human eyes! :p
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... :)
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 4 (4 easyconfigs in total) |
Hm, another issue with Intel MPI on generoso? |
Hmm, yeah, maybe... I wouldn't let this block this PR though, since |
@boegelbot please test @ jsc-zen2 |
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1879595628 processed Message to humans: this is just bookkeeping information for me, |
More info from
looks like a very (very) basic MPI test: https://gitlab.com/petsc/petsc/-/blob/80f88c66aac8f9d1abe2df64bcd926bcfcc2a09a/config/BuildSystem/config/packages/MPI.py#L380 I can reproduce this issue easily when running in an interactive job started with After running |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 8 out of 10 (4 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, and failures in the test reports are not related nor affected by these changes
Going in, thanks @boegel! |
@boegel |
(created using
eb --new-pr
)When building
petsc4py
on top ofPETSc/3.17.4-foss-2022a
, I ran into the following problem during thefrom petsc4py import PETSc
sanity check:This is due to a change in the linking order of SCOTCH libraries to order them alphabetically, which was introduced in #2796 (on my request 🤦 ).
It's vital that
libptscotch
(which providesSCOTCH_dgraphOrderTreeDist
) is linked in afterlibptscotchparmetisv3
(which requiresSCOTCH_dgraphOrderTreeDist
).