-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor branch #6
Conversation
- Fixed ValueError return for mutliple HGNC_ids - Updated merge_overlapping function to return correct df according to docstring. - Moved order in write_bed so collapsing is done after combining coordinates_df and annotation_df. -Write_bed also returns the correct empty df now. -Removed some lines from write_bed into merge_overlapping to make consistent. - Added additional example cmd to script docstring Tests added: - Test for empty annotation_df and correct results. - Test am error is raised for multiple hgnc ids. - Test correct merged_overlapping coordinates returned.
…ecting only NM_ transcripts, this might be removed on consultation. Added section explaining how to use this with VEP. Added example of gff3 tsv.
Hello @RSWilson1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-02-19 09:45:44 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RSWilson1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RSWilson1)
Added changes to cover more with tests and change functionality of some code:
annotation_df
and move code to fit into functions better.annotation_df
andcoordinates_df
.This change is