Allow html elements to be set by liquid variables #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something our theme devs want to do. Previously, we replaced liquid variables with empty spaces, which is fine for most uses but when it's used directly in the html tag this results in: `ERROR: Invalid first character of tag name ' '.` By changing this to `x` we can keep the same number of characters but allow for liquid variables to be used in the tag.
eballantine
force-pushed
the
fix-html-validator-on-liquid-variable-for-tag
branch
from
e0f8c2f to
bbd6b1e
Compare
eballantine
requested review from
a team,
CatalinaTudor,
geoffreymm and
jessehigson
and removed request for
a team
|
just a reminder to publish this after, we've forgotten in the past 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something our theme devs want to do. Previously, we replaced liquid variables with empty spaces, which is fine for most uses but when it's used directly in the html tag this results in:
ERROR: Invalid first character of tag name ' '.By changing this to
xwe can keep the same number of characters but allow for liquid variables to be used in the tag.Minor version update - adding functionality in a backward compatible manner.