Merge pull request #81 from easolhq/fix-html-validator-on-liquid-variable-for-tag

Allow html elements to be set by liquid variables

Author: eballantine

lib/canvas/validators/html.rb

@@ -31,10 +31,10 @@ def extracted_html
       end
 
       # We want to strip out the liquid tags and replace them with the
-      # same number of empty space characters, so that the linter
-      # reports the correct character number.
+      # same number of characters, so that the linter reports the
+      # correct character number.
       def strip_out_liquid(html)
-        html.gsub(LIQUID_TAG_OR_VARIABLE) { |tag| " " * tag.size }
+        html.gsub(LIQUID_TAG_OR_VARIABLE) { |tag| "x" * tag.size }
       end
 
       # We want to strip out the front matter and replace it

lib/canvas/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Canvas
-  VERSION = "4.15.0"
+  VERSION = "4.16.0"
 end

spec/lib/canvas/checks/valid_html_check_spec.rb

@@ -17,7 +17,7 @@
       message = <<~MESSAGE.chop
         Invalid HTML: blocks/hero/block.liquid - \n
         14:16: ERROR: Start tag of nonvoid HTML element ends with '/>', use '>'.
-        <h1>           <foo/>
+        <h1>xxxxxxxxxxx<foo/>
                        ^
       MESSAGE
 

spec/lib/canvas/validators/html_spec.rb

@@ -44,5 +44,13 @@
 
       expect(Canvas::Validator::Html.new(html).validate).to be_truthy
     end
+
+    it "strips out liquid" do
+      html = <<-LIQUID
+        <{{ tag | default: 'div' }}>This is valid html</{{ tag | default: 'div' }}>
+      LIQUID
+
+      expect(Canvas::Validator::Html.new(html).validate).to be_truthy
+    end
   end
 end