Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21397] Parse IDL string for xtypes #4943

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

YangboLong
Copy link
Contributor

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jun 21, 2024
@elianalf elianalf added needs-review PR that is ready to be reviewed to-do labels Jun 24, 2024
@EduPonz EduPonz modified the milestones: v3.0.0, v3.0.1 Jul 19, 2024
@juanlofer-eprosima juanlofer-eprosima changed the title Parse IDL string for xtypes [21397] Parse IDL string for xtypes Jul 22, 2024
@juanlofer-eprosima juanlofer-eprosima modified the milestones: v3.0.1, v3.0.0 Jul 22, 2024
@richiware
Copy link
Member

Review current state. Next should be the testing.

Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Example input:
struct StructMixedArray
{
    short var_short;
    int32 var_array[10];
    float var_multi_array[5][15];
};

Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Handle the case when array size being an identifier instead of integer.
For example:

const long size_1 = 5;
struct ArraySingleDimensionLiteralsShort
{
    short var_array_short[size_1];
};

Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review PR that is ready to be reviewed to-do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants