Fixed the SHM segment smashing while reading with security <2.1.x> #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
rsanchez15
force-pushed
the
bugfix/security-shm/2.1.x
branch
from
b31e7c2
to
4ab9ff2
Compare
|
Build status:
|
MiguelCompany
requested changes
Dec 18, 2020
Comment on lines
56
to
57
| , crypto_payload_(participant->is_secure() ? rec_buffer_size : 0) | ||
| , crypto_submsg_(participant->is_secure() ? rec_buffer_size : 0) |
There was a problem hiding this comment.
Suggested change
| , crypto_payload_(participant->is_secure() ? rec_buffer_size : 0) | |
| , crypto_submsg_(participant->is_secure() ? rec_buffer_size : 0) | |
| , crypto_submsg_(participant->is_secure() ? rec_buffer_size : 0) | |
| , crypto_payload_(participant->is_secure() ? rec_buffer_size : 0) |
Comment on lines
96
to
97
| CDRMessage_t crypto_submsg_; | ||
| SerializedPayload_t crypto_payload_; |
There was a problem hiding this comment.
Suggested change
| CDRMessage_t crypto_submsg_; | |
| SerializedPayload_t crypto_payload_; | |
| CDRMessage_t crypto_submsg_; | |
| //!Buffer to process a decoded payload | |
| SerializedPayload_t crypto_payload_; |
Signed-off-by: RaulSanchez <raul@eprosima.com>
|
Build status:
|
|
Build status:
|
MiguelCompany
approved these changes
Dec 21, 2020
|
@MiguelCompany what do you think? |
I think we can merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of PR #1644 from 2.0.x to 2.1.x