Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the SHM segment smashing while reading with security <2.0.x> [10165] #1644

Merged
merged 7 commits into from
Dec 18, 2020

Conversation

rsanchez15
Copy link
Contributor

This PR includes:

  • Fix the shared memory segment writing access while reading when the RTPS message and sub-messages are encrypted.
  • Communication tests

Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15 rsanchez15 changed the title Fixed the SHM segment smashing while reading with security Fixed the SHM segment smashing while reading with security <2.0.x> [10165] Dec 17, 2020
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany previously approved these changes Dec 17, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor details only

src/cpp/rtps/messages/MessageReceiver.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/messages/MessageReceiver.cpp Show resolved Hide resolved
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: RaulSanchez <raul@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

richiware commented Dec 18, 2020

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Unrelated failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants