Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the SHM segment smashing while reading with security <2.0.x> [10165] #1644

Merged
merged 7 commits into from
Dec 18, 2020
Merged

Fixed the SHM segment smashing while reading with security <2.0.x> [10165] #1644

merged 7 commits into from
Dec 18, 2020

Conversation

rsanchez15
Copy link
Contributor

This PR includes:

  • Fix the shared memory segment writing access while reading when the RTPS message and sub-messages are encrypted.
  • Communication tests

@rsanchez15
Refs #9475: Fixed encrypted RTPS message and submessage decoding
f9577ea 
Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15 rsanchez15 changed the title Fixed the SHM segment smashing while reading with security Fixed the SHM segment smashing while reading with security <2.0.x> [10165] Dec 17, 2020
@rsanchez15
Refs #9475: Added secure communication test for encrypted messages
f1be4b6 
Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15
Refs #9475: Uncrustify
67c04ee 
Signed-off-by: RaulSanchez <raul@eprosima.com>
This was referenced Dec 17, 2020
Merged
Merged
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany previously approved these changes Dec 17, 2020
View reviewed changes
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@rsanchez15
Refs #9475: Added buffer to process decoded submessages
de40179 
Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15
Refs #9475: Added more comments
cda01c2 
Signed-off-by: RaulSanchez <raul@eprosima.com>
MiguelCompany
MiguelCompany requested changes Dec 18, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor details only

src/cpp/rtps/messages/MessageReceiver.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/messages/MessageReceiver.cpp Show resolved Hide resolved
@rsanchez15
Refs #9475: Applied suggested changes
f5e5948 
Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15
Refs #9475: Uncrustify
26f400e 
Signed-off-by: RaulSanchez <raul@eprosima.com>
MiguelCompany
MiguelCompany approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

richiware commented Dec 18, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Unrelated failures.

@MiguelCompany MiguelCompany merged commit 2120518 into 2.0.x Dec 18, 2020
@MiguelCompany MiguelCompany deleted the bug/security-shm branch December 18, 2020 11:45
@IkerLuengo IkerLuengo mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @richiware @MiguelCompany