Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatching tag in package.xml <2.0.x> #1554

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Fix mismatching tag in package.xml <2.0.x> #1554

merged 1 commit into from
Nov 6, 2020

Conversation

ThijsRay
Copy link
Contributor

@ThijsRay ThijsRay commented Nov 6, 2020

Currently, the 2.0.x branch is being used in ROS Foxy [1] [2]. Because the package.xml in this branch is malformed since 669a400, all builds that build ROS 2 from source fail.

Error message:

Error(s) in package '/ros2_foxy/src/eProsima/Fast-DDS/package.xml':
The manifest contains invalid XML:
mismatched tag: line 20, column 22

This pull request fixes this error by changing dev to depend in package.xml.

This fixes the 2.0.x branch, but #1553 fixes this for the master branch.

Signed-off-by: Thijs Raymakers <thijs@raymakers.nl>
@ThijsRay ThijsRay changed the title Fix mismatching tag in package.xml Fix mismatching tag in package.xml <2.0.x> Nov 6, 2020
@MiguelCompany MiguelCompany merged commit da64e87 into eProsima:2.0.x Nov 6, 2020
@ThijsRay ThijsRay deleted the hotfix/mismatched-tag-package-xml-2.0.x branch November 6, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants