Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix singleton in StatisticsBackendData [15841] #172

Merged
merged 13 commits into from
Oct 24, 2022
Merged

Fix singleton in StatisticsBackendData [15841] #172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1e872bf
Refs #15841: Fix singleton in StatisticsBackendData
Oct 6, 2022
cc172a8
Refs #15841: Fix Singleton instance management (with other singleton …
Oct 6, 2022
dc1cfa3
Refs #15841: Fix tests that set monitors ad-hoc and then they fail in…
Oct 7, 2022
9966ae8
Refs #15841: Change gtest version
Oct 7, 2022
c77286a
Refs #15841: Change DomainParticipantFactory from Mock to Fake
Oct 10, 2022
fb37f6a
Refs #15841: Fix failure handle in Monitor creation
Oct 11, 2022
86b6207
Refs #15841: Fix error in test mocking entities
Oct 11, 2022
aacf5cc
Refs #15841: Return to monitor creation and add error handle
Oct 13, 2022
412854d
Refs #15841: apply suggestions
Oct 21, 2022
2e4288c
Refs #15841: apply new suggestions
Oct 24, 2022
049cf32
Refs #15841: apply small suggestions
Oct 24, 2022
642e20a
Refs #15841: uncrustify
Oct 24, 2022
cf468ca
Update src/cpp/StatisticsBackendData.hpp
MiguelCompany Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refs #15841: Fix tests that set monitors ad-hoc and then they fail in… 
… destruction

Signed-off-by: jparisu <javierparis@eprosima.com>
  • Loading branch information
jparisu committed Oct 18, 2022
commit dc1cfa318851f72282834843d429c85a14a88fc3
11 changes: 6 additions & 5 deletions test/unittest/Database/DatabaseStatusTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class database_status_tests : public ::testing::Test
// Simulate that the backend is monitorizing the domain
// NOTE: This is so F*** dangerous, please do not do it again (1)
std::shared_ptr<details::Monitor> monitor = std::make_shared<details::Monitor>();
monitor->id = domain->id;
details::StatisticsBackendData::get_instance()->monitors_by_entity_[domain->id] = monitor;

// Simulate the discover of the entitiy
Expand Down Expand Up @@ -81,11 +82,11 @@ class database_status_tests : public ::testing::Test
}


void TearDown()
{
// NOTE: This is thanks to (1) brilliant idea
details::StatisticsBackendData::get_instance()->monitors_by_entity_.erase(domain->id);
}
// void TearDown()
// {
// // NOTE: This is thanks to (1) brilliant idea
// details::StatisticsBackendData::get_instance()->monitors_by_entity_.erase(domain->id);
// }

std::shared_ptr<Host> host;
std::shared_ptr<User> user;
Expand Down
1 change: 1 addition & 0 deletions test/unittest/StatisticsBackend/IsActiveTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ class is_active_tests : public ::testing::Test

// Simulate that the backend is monitorizing the domain
std::shared_ptr<details::Monitor> monitor = std::make_shared<details::Monitor>();
monitor->id = domain->id;
details::StatisticsBackendData::get_instance()->monitors_by_entity_[domain->id] = monitor;

// Simulate the discover of the entitiy
Expand Down