New DxcBarChart component
#2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jialecl
reviewed
May 27, 2024
Jialecl
reviewed
May 30, 2024
Jialecl
reviewed
May 30, 2024
Jialecl
previously approved these changes
May 30, 2024
…ogy/halstack-react into gomezivann/bar-chart
Jialecl
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
New
DxcBarChartcomponent added to the Halstack Design System. Based on the Figma designs below, it uses Cloudscape's component under the hood.Props table
https://nettle-opera-f35.notion.site/Bar-Chart-d8092551790b467f8e611f0f8033ee91?pvs=4
Additional changes
Some accessibility issues were reported at the Spinner component when the component was undetermined and the
modewas small. Botharia-labelandaria-labelledbyattributes have been included to solve this issues.Additional context
Cloudscape Bar Chart
Halstack Bar Chart Designs