Skip to content

New DxcBarChart component #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 30, 2024
Merged

New DxcBarChart component #2005

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7c70b4f
First iteration of the new Bar Chart component
GomezIvann May 17, 2024
e681c68
Updates to the bar chart component
GomezIvann May 23, 2024
98ed22c
Localization messages added
GomezIvann May 23, 2024
c542f7e
Merge branch 'master' into gomezivann/bar-chart
GomezIvann May 23, 2024
95a4899
Accessibility fixes for the Spinner
GomezIvann May 24, 2024
c4d4066
Updated types based on feedback
GomezIvann May 29, 2024
d002795
Added Bar Chart Jest tests
GomezIvann May 29, 2024
57eaa14
Provisional type descriptions included
GomezIvann May 29, 2024
cc49159
New props included for formatting values
GomezIvann May 29, 2024
d5dbea7
Updated test based on feedback
GomezIvann May 30, 2024
ff1b854
Merge branch 'master' into gomezivann/bar-chart
Jialecl May 30, 2024
953ef4a
Tabs changes
GomezIvann May 30, 2024
7fcdb5f
Merge branch 'gomezivann/bar-chart' of https://github.com/dxc-technol…
GomezIvann May 30, 2024
93254ca
Fix for the Tabs issue
GomezIvann May 30, 2024
38f52ce
Reverting tab changes
GomezIvann May 30, 2024
b7e51cc
Tabs stories updated
GomezIvann May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
365 changes: 354 additions & 11 deletions lib/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"styled-components": "^5.0.1"
},
"dependencies": {
"@cloudscape-design/components": "^3.0.632",
"@radix-ui/react-popover": "^1.0.7",
"@radix-ui/react-tooltip": "^1.0.7",
"color": "^3.1.3",
Expand Down
277 changes: 277 additions & 0 deletions lib/src/bar-chart/BarChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,277 @@
import React from "react";
import Title from "../../.storybook/components/Title";
import ExampleContainer from "../../.storybook/components/ExampleContainer";
import DxcBarChart from "./BarChart";
import { userEvent, within } from "@storybook/test";

export default {
title: "Bar Chart",
component: DxcBarChart,
};

const series = [
{
title: "Series 1",
type: "bar",
data: [
{ x: 0, y: 100000 },
{ x: 1, y: 200000 },
{ x: 2, y: 300000 },
{ x: 3, y: 400000 },
{ x: 4, y: 500000 },
],
},
{
title: "Series 2",
type: "bar",
data: [
{ x: 0, y: 50000 },
{ x: 1, y: 100000 },
{ x: 2, y: 150000 },
{ x: 3, y: 200000 },
{ x: 4, y: 250000 },
],
},
{
title: "Series 3",
type: "bar",
data: [
{ x: 0, y: 200000 },
{ x: 1, y: 400000 },
{ x: 2, y: 600000 },
{ x: 3, y: 800000 },
{ x: 4, y: 1000000 },
],
},
{
title: "Series 4",
type: "bar",
data: [
{ x: 0, y: 100000 },
{ x: 1, y: 200000 },
{ x: 2, y: 400000 },
{ x: 3, y: 700000 },
{ x: 4, y: 900000 },
],
},
{
title: "Series 5",
type: "bar",
data: [
{ x: 0, y: 50000 },
{ x: 1, y: 500000 },
{ x: 2, y: 800000 },
{ x: 3, y: 900000 },
{ x: 4, y: 100000 },
],
},
{
title: "Series 6",
type: "bar",
data: [
{ x: 0, y: 10000 },
{ x: 1, y: 250000 },
{ x: 2, y: 550000 },
{ x: 3, y: 750000 },
{ x: 4, y: 950000 },
],
},
{
title: "Average",
type: "threshold",
y: 400000,
},
];

const BarChart = () => (
<>
<Title title="Basic bar chart" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart
series={[
{
title: "Series 1",
type: "bar",
data: [
{ x: 0, y: 100000 },
{ x: 1, y: 200000 },
{ x: 2, y: 300000 },
{ x: 3, y: 400000 },
{ x: 4, y: 500000 },
],
},
{
title: "Average",
type: "threshold",
y: 300000,
},
]}
xDomain={[0, 1, 2, 3, 4]}
yDomain={[0, 600000]}
/>
</ExampleContainer>
<Title title="Horizontal bar chart" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart
series={[
{
title: "Series 1",
type: "bar",
data: [
{ x: 0, y: 100000 },
{ x: 1, y: 200000 },
{ x: 2, y: 300000 },
],
},
{
title: "Series 2",
type: "bar",
data: [
{ x: 0, y: 50000 },
{ x: 1, y: 100000 },
{ x: 2, y: 150000 },
],
},
]}
xDomain={[0, 1, 2]}
yDomain={[0, 600000]}
horizontalBars
/>
</ExampleContainer>
<Title title="Stacked bar chart" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart series={series as any} xDomain={[0, 1, 2, 3, 4]} yDomain={[0, 5000000]} stackedBars />
</ExampleContainer>
<Title title="Stacked & horizontal bar chart" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart series={series as any} xDomain={[0, 1, 2, 3, 4]} yDomain={[0, 5000000]} stackedBars horizontalBars />
</ExampleContainer>
<Title title="Complete bar chart" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart
chartTitle="Bar Chart"
series={series as any}
xDomain={[0, 1, 2, 3, 4]}
yDomain={[0, 1000000]}
xTitle="X Axis"
yTitle="Y Axis"
showFilter
showLegend
legendTitle="Legend"
/>
</ExampleContainer>
<Title title="Error state" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart series={[]} error="Error loading data." />
</ExampleContainer>
<Title title="Loading state" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart series={[]} loading />
</ExampleContainer>
<Title title="No data" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart series={[]} />
</ExampleContainer>
<Title title="No matching data" theme="light" level={4} />
<ExampleContainer>
<DxcBarChart
series={[
{
title: "Series 1",
type: "bar",
data: [
{ x: 0, y: 100000 },
{ x: 1, y: 200000 },
{ x: 2, y: 300000 },
{ x: 3, y: 400000 },
{ x: 4, y: 500000 },
],
},
{
title: "Series 2",
type: "bar",
data: [
{ x: 0, y: 50000 },
{ x: 1, y: 100000 },
{ x: 2, y: 150000 },
{ x: 3, y: 200000 },
{ x: 4, y: 250000 },
],
},
{
title: "Series 3",
type: "bar",
data: [
{ x: 0, y: 200000 },
{ x: 1, y: 400000 },
{ x: 2, y: 600000 },
{ x: 3, y: 800000 },
{ x: 4, y: 1000000 },
],
},
{
title: "Series 4",
type: "bar",
data: [
{ x: 0, y: 100000 },
{ x: 1, y: 200000 },
{ x: 2, y: 400000 },
{ x: 3, y: 700000 },
{ x: 4, y: 900000 },
],
},
{
title: "Series 5",
type: "bar",
data: [
{ x: 0, y: 50000 },
{ x: 1, y: 500000 },
{ x: 2, y: 800000 },
{ x: 3, y: 900000 },
{ x: 4, y: 100000 },
],
},
{
title: "Series 6",
type: "bar",
data: [
{ x: 0, y: 10000 },
{ x: 1, y: 250000 },
{ x: 2, y: 550000 },
{ x: 3, y: 750000 },
{ x: 4, y: 950000 },
],
},
{
title: "Series 7",
type: "bar",
data: [
{ x: 0, y: 20000 },
{ x: 1, y: 150000 },
{ x: 2, y: 350000 },
{ x: 3, y: 450000 },
{ x: 4, y: 750000 },
],
},
{
title: "Average",
type: "threshold",
y: 400000,
},
]}
xDomain={[0, 1, 2, 3, 4]}
yDomain={[0, 1000000]}
showFilter
xTitle="X Axis"
yTitle="Y Axis"
legendTitle="Legend"
/>
</ExampleContainer>
</>
);

export const Chromatic = BarChart.bind({});
Chromatic.play = async ({ canvasElement }) => {
const canvas = within(canvasElement);
await userEvent.click(canvas.getAllByTitle("Clear selection")[1]);
};
Loading