Skip to content

Update Radix Popover version #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 28, 2023
Merged

Update Radix Popover version #1724

merged 20 commits into from
Nov 28, 2023

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 26, 2023 •
edited
Loading

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary of changes:

Storybook upgrade:

  • storybook package migrated from 6.3.3 to 7.5.3 (latest).
  • chromatic package migrated from 6.3.3 to 8.0.0 (latest).
  • Removed on dark examples.

Radix upgrade

  • @radix-ui/react-popover updated from 0.1.6 to 1.0.7 in the library. This solves the react peer dependency issue.
  • The tests had to be updated to match a few new features of the Radix Popover.
  • The collission detection has change a bit, a few components like the Dropdown have been affected.

Bug fixes

  • Text Input suggestions now appear centred when the clear action is on screen.
  • Radix Popover components' positioning inside fixed containers has been fixed.

Additional context
Radix Popover
Storybook 7.5

Closes #1728 #1723 #1708 #1540 #1469

This was linked to issues Oct 26, 2023
Suggestions container is not centered in DxcTextInput #1540
Closed
Dependency conflicts - halstack-react 9+ / React 18 / NPM 9 #1708
Closed
This was linked to issues Nov 14, 2023
Radix Popover components' positioning inside fixed containers #1469
Closed
Migration to Storybook 7.5 #1728
Closed
Update the version of the Radix popover #1723
Closed
@GomezIvann GomezIvann marked this pull request as ready for review November 14, 2023 11:38
@raquelarrojo raquelarrojo self-requested a review November 15, 2023 07:28
@raquelarrojo raquelarrojo self-assigned this Nov 15, 2023
@Jialecl Jialecl self-requested a review November 15, 2023 13:15
@Jialecl Jialecl self-assigned this Nov 15, 2023
@raquelarrojo raquelarrojo removed their assignment Nov 20, 2023
@raquelarrojo raquelarrojo removed their request for review November 20, 2023 16:04
@Jialecl Jialecl merged commit 381476a into master Nov 28, 2023
@Jialecl Jialecl deleted the gomezivann/radix-popover-update branch November 28, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@GomezIvann @Jialecl @raquelarrojo