Skip to content

Chip specs inconsistencies fixed #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Chip specs inconsistencies fixed #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
324 changes: 136 additions & 188 deletions website/screens/components/chip/specs/ChipSpecsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,182 +73,120 @@ const sections = [
subSections: [
{
title: "Color",
subSections: [
{
title: "On-light",
content: (
<DxcTable>
<thead>
<tr>
<th>Component token</th>
<th>Element</th>
<th>Core token</th>
<th>Value</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<Code>backgroundColor</Code>
</td>
<td>Chip container</td>
<td>
<Code>color-grey-200</Code>
</td>
<td>#e6e6e6</td>
</tr>
<tr>
<td>
<Code>disabledBackgroundColor</Code>
</td>
<td>Chip container:disabled</td>
<td>
<Code>color-grey-100</Code>
</td>
<td>#f2f2f2</td>
</tr>
<tr>
<td>
<Code>fontColor</Code>
</td>
<td>Label</td>
<td>
<Code>color-black</Code>
</td>
<td>#000000</td>
</tr>
<tr>
<td>
<Code>disabledFontcolor</Code>
</td>
<td>Label:disabled</td>
<td>
<Code>color-grey-500</Code>
</td>
<td>#999999</td>
</tr>
<tr>
<td>
<Code>focusColor</Code>
</td>
<td>Focus outline</td>
<td>
<Code>color-blue-600</Code>
</td>
<td>#0095ff</td>
</tr>
<tr>
<td>
<Code>iconColor</Code>
</td>
<td>Icon</td>
<td>
<Code>color-black</Code>
</td>
<td>#000000</td>
</tr>
<tr>
<td>
<Code>disabledIconColor</Code>
</td>
<td>Icon:disabled</td>
<td>
<Code>color-grey-500</Code>
</td>
<td>#999999</td>
</tr>
</tbody>
</DxcTable>
),
},
{
title: "On-dark",
content: (
<DxcTable>
<thead>
<tr>
<th>Component token</th>
<th>Element</th>
<th>Core token</th>
<th>Value</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<Code>backgroundColorOnDark</Code>
</td>
<td>Chip container</td>
<td>
<Code>color-grey-700</Code>
</td>
<td>#666666</td>
</tr>
<tr>
<td>
<Code>disabledBackgroundColorOnDark</Code>
</td>
<td>Chip container:disabled</td>
<td>
<Code>color-grey-800</Code>
</td>
<td>#4d4d4d</td>
</tr>
<tr>
<td>
<Code>fontcolorOnDark</Code>
</td>
<td>Label</td>
<td>
<Code>color-white</Code>
</td>
<td>#ffffff</td>
</tr>
<tr>
<td>
<Code>disabledfontcolorOnDark</Code>
</td>
<td>Label:disabled</td>
<td>
<Code>color-grey-500</Code>
</td>
<td>#999999</td>
</tr>
<tr>
<td>
<Code>focusColorOnDark</Code>
</td>
<td>Focus outline</td>
<td>
<Code>color-blue-600</Code>
</td>
<td>#0095ff</td>
</tr>
<tr>
<td>
<Code>iconColorOnDark</Code>
</td>
<td>Icon</td>
<td>
<Code>color-white</Code>
</td>
<td>#ffffff</td>
</tr>
<tr>
<td>
<Code>iconColorOnDark</Code>
</td>
<td>Icon:disabled</td>
<td>
<Code>color-grey-500</Code>
</td>
<td>#999999</td>
</tr>
</tbody>
</DxcTable>
),
},
],
content: (
<DxcTable>
<thead>
<tr>
<th>Component token</th>
<th>Element</th>
<th>Core token</th>
<th>Value</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<Code>activeIconColor</Code>
</td>
<td>Container:active</td>
<td>
<Code>color-black</Code>
</td>
<td>#000000</td>
</tr>
<tr>
<td>
<Code>backgroundColor</Code>
</td>
<td>Container</td>
<td>
<Code>color-grey-200</Code>
</td>
<td>#e6e6e6</td>
</tr>
<tr>
<td>
<Code>borderColor</Code>
</td>
<td>Container:border</td>
<td>
<Code>color-transparent</Code>
</td>
<td>transparent</td>
</tr>
<tr>
<td>
<Code>disabledBackgroundColor</Code>
</td>
<td>Container:disabled</td>
<td>
<Code>color-grey-100</Code>
</td>
<td>#f2f2f2</td>
</tr>
<tr>
<td>
<Code>disabledFontcolor</Code>
</td>
<td>Label:disabled</td>
<td>
<Code>color-grey-500</Code>
</td>
<td>#999999</td>
</tr>
<tr>
<td>
<Code>disabledIconColor</Code>
</td>
<td>Icon:disabled</td>
<td>
<Code>color-grey-500</Code>
</td>
<td>#999999</td>
</tr>
<tr>
<td>
<Code>focusColor</Code>
</td>
<td>Focus outline</td>
<td>
<Code>color-blue-600</Code>
</td>
<td>#0095ff</td>
</tr>
<tr>
<td>
<Code>fontColor</Code>
</td>
<td>Label</td>
<td>
<Code>color-black</Code>
</td>
<td>#000000</td>
</tr>
<tr>
<td>
<Code>hoverIconColor</Code>
</td>
<td>Container:hover</td>
<td>
<Code>color-grey-900</Code>
</td>
<td>#333333</td>
</tr>
<tr>
<td>
<Code>iconColor</Code>
</td>
<td>Icon</td>
<td>
<Code>color-grey-800</Code>
</td>
<td>#4d4d4d</td>
</tr>
</tbody>
</DxcTable>
),
},
{
title: "Typography",
Expand Down Expand Up @@ -322,39 +260,49 @@ const sections = [
<tbody>
<tr>
<td>
<Code>labelMarginLeft</Code>
<Code>contentPaddingLeft</Code>
</td>
<td>Label</td>
<td>Container</td>
<td>
<Code>spacing-8</Code>
<Code>spacing-16</Code>
</td>
<td>0.5rem / 8px</td>
<td>1rem / 16px</td>
</tr>
<tr>
<td>
<Code>labelMarginRight</Code>
<Code>contentPaddingRight</Code>
</td>
<td>Label</td>
<td>Container</td>
<td>
<Code>spacing-8</Code>
<Code>spacing-16</Code>
</td>
<td>0.5rem / 8px</td>
<td>1rem / 16px</td>
</tr>
<tr>
<td>
<Code>containerPaddingLeft</Code>
<Code>contentPaddingTop</Code>
</td>
<td>Container</td>
<td>
<Code>spacing-8</Code>
<Code>spacing-0</Code>
</td>
<td>0.5rem / 8px</td>
<td>0</td>
</tr>
<tr>
<td>
<Code>containerPaddingRight</Code>
<Code>contentPaddingBottom</Code>
</td>
<td>Container</td>
<td>
<Code>spacing-0</Code>
</td>
<td>0</td>
</tr>
<tr>
<td>
<Code>iconSpacing</Code>
</td>
<td>Icon</td>
<td>
<Code>spacing-8</Code>
</td>
Expand Down
Binary file modified website/screens/components/chip/specs/images/chip_anatomy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified website/screens/components/chip/specs/images/chip_specs.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified website/screens/components/chip/specs/images/chip_states_action.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified website/screens/components/chip/specs/images/chip_states_container.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.