Skip to content

Chip specs inconsistencies fixed #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

Chip specs inconsistencies fixed #1712

merged 1 commit into from
Oct 19, 2023

Conversation

@raquelarrojo
Copy link
Collaborator

@raquelarrojo raquelarrojo commented Oct 17, 2023 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Several fixes in chip specs:

  • containerPaddingLeft and containerPaddingRight renamed as contentPaddingLeft and contentPaddingRight.
  • Changed their values to 16px (instead of 8px) as they are in UI kit and in implementation.
  • Added contentPaddingTop and contentPaddingBottom tokens.
  • labelMarginLeft and labelMarginRight removed since they do not exist.
  • iconSpacing token added.
  • Images in specs updated since they were showing 8px in padding instead of 16px.
  • Added several color tokens that were left.

Closes #1709

@raquelarrojo raquelarrojo marked this pull request as ready for review October 17, 2023 15:35
@raquelarrojo raquelarrojo changed the title Change in chip specs Fixes inconsistencies in chip specs Oct 17, 2023
@raquelarrojo raquelarrojo changed the title Fixes inconsistencies in chip specs Chip specs inconsistencies fixed Oct 17, 2023
@jsuarezgonz jsuarezgonz self-assigned this Oct 19, 2023
@jsuarezgonz jsuarezgonz merged commit 2159242 into master Oct 19, 2023
@jsuarezgonz jsuarezgonz deleted the rarrojolopez-chip branch October 19, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuarezgonz jsuarezgonz jsuarezgonz approved these changes

Assignees

@jsuarezgonz jsuarezgonz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chip spacing tokens are incorrect in specs page

3 participants

@raquelarrojo @jsuarezgonz