-
Notifications
You must be signed in to change notification settings - Fork 17
Updates to Sidenav component #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jialecl
reviewed
May 9, 2023
Collaborator
|
The hover collapsed group title does not look correct in collapsed snapshots from chromatic. |
Collaborator
|
Also I noticed that we don't have a visual test that covers the active state. |
Collaborator
Author
|
We are closing this pull request and continuing the work in a new one since we have made too many changes to fix a Chromatic issue. You can keep track of the work there: #1596. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Summary of changes in the Sidenav component:
childrenhas changed its type fromstringtoReact.ReactNode.Closes #1587