Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented May 11, 2023

Checklist

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary of changes in the Sidenav component:

  • DxcSidenav.Link prop children has changed its type from string to React.ReactNode.
  • Specs updated:
    • Removed line heights to be able to properly align text inside a Sidenav link.
    • Removed unnecessary margin-right for SVGs inside the compound component Title.
    • Removed React.Children from the implementation and using instead React Context API and other resources. In the new React documentation site, they have established React.Children as a legacy API and recommend not to use it whenever possible (https://react.dev/reference/react/Children).
  • Documentation updated:
    • More logical hierarchy and improved descriptions.
    • Updated children's prop type.
    • Updated description for some props.

Closes #1587

@GomezIvann GomezIvann mentioned this pull request May 11, 2023
5 tasks
@GomezIvann GomezIvann requested a review from Jialecl May 11, 2023 13:54
@GomezIvann GomezIvann marked this pull request as ready for review May 11, 2023 14:50
@Jialecl Jialecl merged commit 22b474c into master May 12, 2023
@Jialecl Jialecl deleted the gomezivann/sidenav-update branch May 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Sidenav.Link children prop type

3 participants