Skip to content

Conversation

@aidamag
Copy link
Contributor

@aidamag aidamag commented Oct 25, 2022

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Changed website to match changes from #1338. Waiting for this changes to be merged to change the version of halstack.

Description
Added new prop navSubtitle for Section and HeadingLink components. We were using title for navigation and title of the section and subsection so it is not matching the new navigation made in the fix.
Now, to have unique navigation, subsections are composed by section-title + subsection-title.

Closes #1338

@aidamag aidamag marked this pull request as ready for review October 25, 2022 11:30
@raquelarrojo raquelarrojo self-requested a review October 25, 2022 13:58
@raquelarrojo raquelarrojo self-assigned this Oct 25, 2022
@raquelarrojo raquelarrojo merged commit 2f47857 into master Oct 25, 2022
@raquelarrojo raquelarrojo deleted the aida-quicknav-website branch October 25, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants