Fixed navigation using repeated sublinks in QuickNav #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelarrojo
requested changes
Oct 21, 2022
added 3 commits
October 21, 2022 14:46
5 tasks
raquelarrojo
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Navigation using sublinks wasn't working fine if the sublink text is the same as other sublink of other section in the QuickNav component.
Description
Added parent label to sublinks
href. So for example, if parent label isoverviewand sublink isintroduction, navigation for sublink will beoverview-introduction.Besides, updated stories with working links and sublinks. Removed unused
idprop from array.Screenshots
Closes #1323