Skip to content

Comments

Reservation support#3

Merged
0xRobin merged 3 commits intomasterfrom
reservation-support
Feb 5, 2026
Merged

Reservation support#3
0xRobin merged 3 commits intomasterfrom
reservation-support

Conversation

@0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Feb 5, 2026

No description provided.

0xRobin and others added 3 commits February 5, 2026 12:04
The previous check matched any query starting with 'SET @@reservation',
including typos like 'SET @@Reservations' or 'SET @@RESERVATION_ID'.
Now checking for '=' or space after 'RESERVATION' to ensure exact match.
@cursor
Copy link

cursor bot commented Feb 5, 2026

PR Summary

Medium Risk
Changes how every query text is constructed/executed when reservation is set (multi-statement SQL), which could affect compatibility with clients/queries that don’t support scripting or rely on exact SQL text.

Overview
Adds DSN-level reservation support by parsing reservation (or legacy reservation_id) from the connection string and storing it in driver config.

When configured, the driver now transparently prefixes executed SQL with a SET @@reservation='...' statement (escaping quotes and avoiding double-prefixing) so queries run under the specified reservation; tests were updated to allow overriding the test DSN via BIGQUERY_TEST_DSN, and README documents the new DSN option.

Written by Cursor Bugbot for commit fe532d3. Configure here.

@0xRobin 0xRobin merged commit 18684cf into master Feb 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants