Skip to content

Comments

Reservation prefix check#2

Merged
0xRobin merged 1 commit intoreservation-supportfrom
cursor/reservation-prefix-check-18fc
Feb 5, 2026
Merged

Reservation prefix check#2
0xRobin merged 1 commit intoreservation-supportfrom
cursor/reservation-prefix-check-18fc

Conversation

@cursor
Copy link

@cursor cursor bot commented Feb 5, 2026

Fix applyReservation to correctly identify SET @@RESERVATION statements, preventing incorrect skipping of DSN reservations due to overly broad prefix matching.


The previous check matched any query starting with 'SET @@reservation',
including typos like 'SET @@Reservations' or 'SET @@RESERVATION_ID'.
Now checking for '=' or space after 'RESERVATION' to ensure exact match.
@cursor
Copy link
Author

cursor bot commented Feb 5, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@0xRobin 0xRobin marked this pull request as ready for review February 5, 2026 11:15
@0xRobin 0xRobin merged commit fe532d3 into reservation-support Feb 5, 2026
@cursor
Copy link
Author

cursor bot commented Feb 5, 2026

PR Summary

Low Risk
Small, localized string-matching change that only affects when reservation statements are auto-injected into queries.

Overview
Tightens applyReservation’s detection of existing SET @@RESERVATION statements so the driver only skips injecting the DSN reservation when the query explicitly sets reservation via SET @@RESERVATION= or SET @@RESERVATION , rather than any broader prefix match.

Written by Cursor Bugbot for commit a8b2eff. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants