Revert setting HomeCollectionView backgroundColor #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaceklyp
approved these changes
Feb 24, 2022
samsymons
added a commit
that referenced
this pull request
Feb 28, 2022
# By Jacek Łyp (4) and others # Via Chris Brind (2) and others * develop: (22 commits) Revert "Fix omnibar subscribing to notifications multiple times" Fix omnibar subscribing to notifications multiple times Update build number Move bookmark folders plural to stringsdict (#1059) Explicitly hide suggestions tray if we do not show tray for favorites (#1053) Update BSK (#1071) Revert setting HomeCollectionView backgroundColor (#1070) Content blocking rules caching (#1068) Improvements to loc import script (#1060) Use config for autofill (#1064) Allow SwiftLint installed by mint (#1056) bump version new tds url (#1062) Remove URL stripping experiment (#1050) Persist Auto Clear settings when they change (#1055) Set version to 7.65.9 Update translations (#1052) Integration of BSK Content Blocking stack (#1042) Fix dax dialog presentation (#1035) Widget Education (#1040) ... # Conflicts: # DuckDuckGo/Base.lproj/Settings.storyboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1201852545282569/f
Tech Design URL:
CC:
Description:
Due to previous fix for https://app.asana.com/0/414235014887631/1201019331404849 done in 048971a it turned out that Dax logo is displayed from a VC beneath the current one hence the requirement for clear background.
Steps to test this PR:
Reproduced when no favourites are present.
Orientation Testing:
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM