Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Education #1040

Merged
merged 28 commits into from
Feb 7, 2022
Merged

Widget Education #1040

merged 28 commits into from
Feb 7, 2022

Conversation

jaceklyp
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1200189110180410/f

Description:
Introduce a new Home screen message that informs users on how to install the app widget within iOS system.

Steps to test this PR:

  1. Make sure you run at least iOS 14.0.
  2. Since the feature is part of the experiment make sure to comment out the variantManager code in HomeMessageStorage and in Settings.
  3. You should be able to see the home message on the Home screen.
  4. Once entered you can see the modal with instructions on how to add the app widget.
  5. Same screen can be seen from the Settings under the "Add Widget to Home Screen" cell.
  6. Once dismissed it should never appear again.

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPad

OS Testing:

  • iOS 13 (the feature shouldn't be visible there)
  • iOS 14
  • iOS 15

Theme Testing:

  • Light theme
  • Dark theme

jaceklyp added 21 commits January 14, 2022 16:41
@jaceklyp
Introduce AddWidgetView screen
154beeb
@jaceklyp
Add new copy
1cdbb58
@jaceklyp
Add Home Message Cell to the Home screen
20783c2
@jaceklyp
Rename AddWidget to WidgetEducation
ae746c3
@jaceklyp
Fix theme issue affecting navigation bars and other system components…
16b30b6 
… when it is manually overriden in the app

updateUserInterfaceStyle method was being called in willEnterForeground which is not called after cold start
@jaceklyp
Remove unused copies
99afb19
@jaceklyp
Open WidgetEducation in modal with navigation bar
db65a0f
@jaceklyp
Add pixels
f00313f
@jaceklyp
Make HomeMessageView compliant with iOS 14
5114567
@jaceklyp
Remove unused code and empty lines
6bcce3d
@jaceklyp
Remove unsued code around the old home message
8b78a1b
@jaceklyp
Remove todos, empty lines and warnings
da5cff5
@jaceklyp
Turn literal into const
c6a3f18
@jaceklyp
Add widget education as variant to the manager
9d4f729
@jaceklyp
Drop the suffix for WidgetEducationHomeMessageViewModel
8a8d944
@jaceklyp
Pass the VariantManager to the Storage and change the logic when to d…
36cf233 
…isplay widgetEducation
@jaceklyp
Fix issue for image not showing on WidgetEducationView
0b0f643
@jaceklyp
Fix issue with image alignment
a54a406
@jaceklyp
Do not show WidgetEducation feature in settings if it shouldn't be shown
ec5f567
@jaceklyp
Do not show widget education if app has been open from widget
49150f1
@jaceklyp
Merge branch 'develop' into feature/jacek/widgets-education
c7cf136 
# Conflicts:
#	Core/VariantManager.swift
@jaceklyp jaceklyp changed the title Feature/jacek/widgets education Widget Education Jan 26, 2022
@brindy brindy self-assigned this Jan 26, 2022
brindy
brindy approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test on a couple of different simulators, including iPad, and with double length text enabled.

A few minor comments, but generally LGTM! Nice work.

Feel free to merge once you fix them and get a thumbs up on your product review.

Core/VariantManager.swift Outdated Show resolved Hide resolved
DuckDuckGo/HomeMessageView.swift Outdated Show resolved Hide resolved
DuckDuckGo/HomeMessageView.swift Outdated Show resolved Hide resolved
DuckDuckGo/HomeMessageView.swift Show resolved Hide resolved
DuckDuckGo/HomeMessageViewModel.swift Show resolved Hide resolved
DuckDuckGo/WidgetEducationView.swift Show resolved Hide resolved
@brindy brindy assigned jaceklyp and unassigned brindy Feb 3, 2022
@jaceklyp jaceklyp merged commit 8c90f83 into develop Feb 7, 2022
@jaceklyp jaceklyp deleted the feature/jacek/widgets-education branch February 7, 2022 16:55
samsymons added a commit that referenced this pull request Feb 8, 2022
@samsymons
Merge branch 'develop' into sam/update-bsk-to-release-branch
78c7312 
* develop:
  Fix dax dialog presentation  (#1035)
  Widget Education (#1040)
  Set version to 7.65.8
  Set the HomeCollectionView backgroundColor according to theme (#1047)
jaceklyp added a commit that referenced this pull request Feb 11, 2022
@jaceklyp
Widget Education (#1040)
f5a3a4f 
* Introduce AddWidgetView screen

* Add new copy

* Add Home Message Cell to the Home screen

* Rename AddWidget to WidgetEducation

* Fix theme issue affecting navigation bars and other system components when it is manually overriden in the app

updateUserInterfaceStyle method was being called in willEnterForeground which is not called after cold start

* Remove unused copies

* Open WidgetEducation in modal with navigation bar

* Add pixels

* Make HomeMessageView compliant with iOS 14

* Remove unused code and empty lines

* Remove unsued code around the old home message

* Remove todos, empty lines and warnings

* Turn literal into const

* Add widget education as variant to the manager

* Drop the suffix for WidgetEducationHomeMessageViewModel

* Pass the VariantManager to the Storage and change the logic when to display widgetEducation

* Fix issue for image not showing on WidgetEducationView

* Fix issue with image alignment

* Do not show WidgetEducation feature in settings if it shouldn't be shown

* Do not show widget education if app has been open from widget

* Design adjustments

* Import translations

* Fix tests

* Use lets instead of vars

* Stop allocating weight for voice search

* Make the action closure the last thing so it can benefit from closure style when constructing

Co-authored-by: Jacek Łyp <jlyp@duckduckgo.com>
samsymons added a commit that referenced this pull request Feb 28, 2022
@samsymons
Merge branch 'develop' into sam/mac-waitlist
b5d0826 
# By Jacek Łyp (4) and others
# Via Chris Brind (2) and others
* develop: (22 commits)
  Revert "Fix omnibar subscribing to notifications multiple times"
  Fix omnibar subscribing to notifications multiple times
  Update build number
  Move bookmark folders plural to stringsdict (#1059)
  Explicitly hide suggestions tray if we do not show tray for favorites (#1053)
  Update BSK (#1071)
  Revert setting HomeCollectionView backgroundColor (#1070)
  Content blocking rules caching (#1068)
  Improvements to loc import script (#1060)
  Use config for autofill (#1064)
  Allow SwiftLint installed by mint (#1056)
  bump version
  new tds url (#1062)
  Remove URL stripping experiment (#1050)
  Persist Auto Clear settings when they change (#1055)
  Set version to 7.65.9
  Update translations (#1052)
  Integration of BSK Content Blocking stack (#1042)
  Fix dax dialog presentation  (#1035)
  Widget Education (#1040)
  ...

# Conflicts:
#	DuckDuckGo/Base.lproj/Settings.storyboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

@amddg44 amddg44 Awaiting requested review from amddg44

@Bunn Bunn Awaiting requested review from Bunn

@bwaresiak bwaresiak Awaiting requested review from bwaresiak

@miasma13 miasma13 Awaiting requested review from miasma13

@samsymons samsymons Awaiting requested review from samsymons

@THISISDINOSAUR THISISDINOSAUR Awaiting requested review from THISISDINOSAUR

Assignees

@jaceklyp jaceklyp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaceklyp @brindy