Adds the networkProtection remote subfeatures #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# By Sam Symons (2) and others # Via GitHub * main: Update WireGuard version (#460) Merge Hotfix 74.0.1-1 (#465) SwiftLint fixes part 3 (#462) Moved iOS Extension to BSK (#458) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#431) feat: duck player v2 (#451) # Conflicts: # Sources/BrowserServicesKit/PrivacyConfig/AppPrivacyConfiguration.swift # Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift
* main: Change service name for NetP auth tokens. (#479)
diegoreymendez
changed the title
diegoreymendez
commented
Aug 29, 2023
samsymons
reviewed
Sep 1, 2023
Sources/BrowserServicesKit/PrivacyConfig/AppPrivacyConfiguration.swift
Outdated
Show resolved
Hide resolved
diegoreymendez
deleted the
diego/waitlist-beta-disable-feature-flag-2
branch
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 3, 2023
Task/Issue URL: https://app.asana.com/0/0/1205381133187306/f ## Related PRs BSK PR: duckduckgo/BrowserServicesKit#483 iOS PR: duckduckgo/iOS#1967 ## Description Adds logic to handle the remote `waitlistBetaActive` subfeature, and to reset Network Protection once the beta is no longer active.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Sep 3, 2023
Task/Issue URL: https://app.asana.com/0/0/1205381133187310/f ## Related PRs BSK PR: duckduckgo/BrowserServicesKit#483 macOS PR: duckduckgo/macos-browser#1562 ## Description Integrates some of the latest changes from BSK. -------- Co-authored-by: Sam Symons <sam@samsymons.com>
samsymons
added a commit
that referenced
this pull request
Sep 4, 2023
# By Diego Rey Mendez # Via GitHub * main: Adds the networkProtection remote subfeatures (#483) # Conflicts: # Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205381133187308/f
iOS PR: duckduckgo/iOS#1967
macOS PR: duckduckgo/macos-browser#1562
What kind of version bump will this require?: Minor
Description
Adds the waitlist remote flags.
Tests:
Test using the macOS PR.
Internal references:
Software Engineering Expectations
Technical Design Template