Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run PR checks on all PRs #470

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Run PR checks on all PRs #470

merged 1 commit into from
Aug 22, 2023

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Aug 22, 2023 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1205320678425969/f
iOS PR: N/A
macOS PR: N/A
What kind of version bump will this require?: None, this is just a CI change

Optional:

Tech Design URL:
CC: @ayoy

Description:

This PR updates the PR checks workflow to run checks on all PRs, not just those targeting main. This allows us to use stacked PRs in BSK.

Steps to test this PR:

Either:

  1. Check this PR and verify that it has run PR checks

Or:

  1. Create a branch off of this PR, and open it as a PR against this branch
  2. Check that PR checks run

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons mentioned this pull request Aug 22, 2023
Closed
@samsymons samsymons requested a review from ayoy August 22, 2023 03:57
ayoy
ayoy approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samsymons samsymons merged commit c26b346 into main Aug 22, 2023
@samsymons samsymons deleted the sam/run-pr-checks-on-stacked-prs branch August 22, 2023 13:27
samsymons added a commit that referenced this pull request Aug 23, 2023
@samsymons
Merge branch 'main' into sam/netp-waitlist
926c07a 
* main:
  Only throw syncIsActive error on scheduled database cleanups (#473)
  Small improvements to `KeychainType`. (#469)
  Swiftlint auto-fixes (#472)
  Run checks on all PRs, not just those targeting main. (#470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@samsymons samsymons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @ayoy