Skip to content

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Oct 29, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382557175163?focus=true

Description

Adds sync devices attributed metric

Steps to test this PR

Use logcat filter tag~:"AttributedMetrics"

Feature 1

  • Fresh install (including removing ddg folder)
  • Ensure Client status running: true -> isActive: true, isEnabled: true
  • skip onboarding
  • Create a sync account
  • After creating the account you should see Fired pixel user_synced_device with params {device_count=1}
  • Now you need another device
  • Go to Sync settings
  • Sync with Another device
  • Read the QR code from your device account (accessing via Sync with another device inside Sync)
  • After both devices connect
  • Ensure you see Fired pixel user_synced_device with params {device_count=2}

Feature 2

  • Fresh install (including removing ddg folder)
  • Ensure Client status running: true -> isActive: true, isEnabled: true
  • skip onboarding
  • Inside FF inventory with syncDevices FF disabled
  • Repeat the above steps for sync, no pixels emitted, metric is disabled

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from ed9c9c0 to 1c2f8d6 Compare October 29, 2025 21:21
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from c806241 to ae51b0a Compare October 29, 2025 21:24
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from 1c2f8d6 to 8dc4fdc Compare October 29, 2025 21:24
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from ae51b0a to 2a80cb9 Compare October 29, 2025 22:32
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from 8dc4fdc to 1c17f75 Compare October 29, 2025 22:32
@cmonfortep cmonfortep marked this pull request as ready for review October 29, 2025 22:33
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from 2a80cb9 to 25fae75 Compare October 29, 2025 23:11
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from 1c17f75 to 4252ca2 Compare October 29, 2025 23:11
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from 25fae75 to e756157 Compare October 30, 2025 09:01
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from 4252ca2 to 339897f Compare October 30, 2025 09:01
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from e756157 to 2d26775 Compare October 31, 2025 11:57
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from 339897f to db8b511 Compare October 31, 2025 11:57
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from 2d26775 to b3c04fc Compare November 4, 2025 12:40
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from db8b511 to c7ecaac Compare November 4, 2025 12:40
@marcosholgado marcosholgado self-assigned this Nov 4, 2025
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from b3c04fc to ae26108 Compare November 4, 2025 13:48
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch 2 times, most recently from b63c936 to dc606a2 Compare November 4, 2025 14:11
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from ae26108 to 9025cfb Compare November 6, 2025 12:06
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from dc606a2 to 768b630 Compare November 6, 2025 12:06
Task/Issue URL:
https://app.asana.com/1/137249556945/project/72649045549333/task/1211382919613023?focus=true

### Description
Remove default params from attributed metrics pixels.
Pixel renaming to use `attributed_metric` as prefix.
Add version as metric param (representing bucket version).
Includes sending origin, or install date as fallback.
Removes stored data outside monitoring window.


### Steps to test this PR
This will be tested by privacy team to ensure:
- we don't include default params
- we strip form factor from pixel (no phone / tablet)
- we include origin or install date
- buckets include their version

Go to `PrivacyFeatureName` class and replace url by
`https://api.jsonblob.com/019a4fb1-89b3-7971-8c77-ab77969a5874`
So it can be smoke tested optionally, to validate those parts.

### UI changes
| Before  | After |
| ------ | ----- |
!(Upload before screenshot)|(Upload after screenshot)|
@cmonfortep cmonfortep merged commit 8a0130d into feature/cristian/subscription_attributed_metric Nov 6, 2025
5 of 6 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/sync_attributed_metric branch November 6, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants