-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Sync devices attributed metric #7030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmonfortep
merged 2 commits into
feature/cristian/subscription_attributed_metric
from
feature/cristian/sync_attributed_metric
Nov 6, 2025
Merged
Sync devices attributed metric #7030
cmonfortep
merged 2 commits into
feature/cristian/subscription_attributed_metric
from
feature/cristian/sync_attributed_metric
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2025
Contributor
Author
11 tasks
ed9c9c0 to
1c2f8d6
Compare
c806241 to
ae51b0a
Compare
1c2f8d6 to
8dc4fdc
Compare
ae51b0a to
2a80cb9
Compare
8dc4fdc to
1c17f75
Compare
2a80cb9 to
25fae75
Compare
1c17f75 to
4252ca2
Compare
25fae75 to
e756157
Compare
4252ca2 to
339897f
Compare
e756157 to
2d26775
Compare
339897f to
db8b511
Compare
2d26775 to
b3c04fc
Compare
db8b511 to
c7ecaac
Compare
marcosholgado
approved these changes
Nov 4, 2025
Contributor
marcosholgado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b3c04fc to
ae26108
Compare
b63c936 to
dc606a2
Compare
ae26108 to
9025cfb
Compare
dc606a2 to
768b630
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382919613023?focus=true ### Description Remove default params from attributed metrics pixels. Pixel renaming to use `attributed_metric` as prefix. Add version as metric param (representing bucket version). Includes sending origin, or install date as fallback. Removes stored data outside monitoring window. ### Steps to test this PR This will be tested by privacy team to ensure: - we don't include default params - we strip form factor from pixel (no phone / tablet) - we include origin or install date - buckets include their version Go to `PrivacyFeatureName` class and replace url by `https://api.jsonblob.com/019a4fb1-89b3-7971-8c77-ab77969a5874` So it can be smoke tested optionally, to validate those parts. ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
8a0130d
into
feature/cristian/subscription_attributed_metric
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382557175163?focus=true
Description
Adds sync devices attributed metric
Steps to test this PR
Use logcat filter
tag~:"AttributedMetrics"Feature 1
Client status running: true -> isActive: true, isEnabled: trueFired pixel user_synced_device with params {device_count=1}Fired pixel user_synced_device with params {device_count=2}Feature 2
Client status running: true -> isActive: true, isEnabled: truesyncDevicesFF disabledUI changes