-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding search related attributed metrics #6899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmonfortep
merged 2 commits into
feature/cristian/attributed_metrics_internal_dev_settings
from
feature/cristian/search_attributed_metric
Nov 6, 2025
Merged
Adding search related attributed metrics #6899
cmonfortep
merged 2 commits into
feature/cristian/attributed_metrics_internal_dev_settings
from
feature/cristian/search_attributed_metric
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Contributor
Author
831e0ec to
c8c63fb
Compare
12d236a to
6a65b73
Compare
3 tasks
2106b08 to
bedf6b7
Compare
6a65b73 to
6129721
Compare
bedf6b7 to
5fd75af
Compare
6129721 to
83ab535
Compare
5fd75af to
6a6bd27
Compare
4738c79 to
e0ba965
Compare
cmonfortep
commented
Oct 8, 2025
app/src/internal/java/com/duckduckgo/app/statistics/StatisticsInternalInfoView.kt
Show resolved
Hide resolved
cmonfortep
commented
Oct 8, 2025
...-impl/src/main/java/com/duckduckgo/app/attributed/metrics/impl/RealAttributedMetricClient.kt
Show resolved
Hide resolved
542fd17 to
ec70268
Compare
...d-metrics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/SearchAttributedMetric.kt
Outdated
Show resolved
Hide resolved
...trics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/SearchDaysAttributedMetric.kt
Outdated
Show resolved
Hide resolved
...ed-metrics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/store/EventRepository.kt
Outdated
Show resolved
Hide resolved
673c16c to
2f3357b
Compare
6a6bd27 to
56ec903
Compare
2f3357b to
28ebece
Compare
cmonfortep
commented
Oct 16, 2025
| import dagger.SingleInstanceIn | ||
| import javax.inject.Inject | ||
|
|
||
| @ContributesBinding(AppScope::class) |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this bit on a different PR. "Unrelated"
This was referenced Oct 17, 2025
marcosholgado
approved these changes
Oct 20, 2025
Contributor
marcosholgado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
78547d9 to
5e2e3da
Compare
28ebece to
90dafbc
Compare
38 tasks
5e2e3da to
b0525e6
Compare
90dafbc to
a8eb8a7
Compare
This was referenced Oct 29, 2025
b0525e6 to
78c4bd9
Compare
a8eb8a7 to
efb097e
Compare
78c4bd9 to
075c16c
Compare
efb097e to
287bc5e
Compare
075c16c to
8342549
Compare
287bc5e to
77f3862
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382557175157?focus=true ### Description Adds retention metric as per specs in https://app.asana.com/1/137249556945/project/1206716555947156/task/1211301604929607?focus=true ### Steps to test this PR While testing this PR you need to add the following in your logcat filter: `tag~:"AttributedMetrics"` _Feature 1_ - [x] We need fresh install (including removing DDG folder in file system) - [x] Open the app - [x] wait until "skip onboarding" appears - [x] After downloading privacy config and atb init, you should see `Client status running: true -> isActive: true, isEnabled: true` - [x] Skip onboarding, and go to the browser - [x] Go to settings -> `Attributed Metrics Dev Settings` - [x] Update app retention atb with `v502-1` (and click save) - [x] Update installation date with 2d ago (and click save) - [x] Close the app, open it again (or fire button) - [x] Ensure `Fired pixel user_retention_week with params {count=1}` - [x] Update app retention atb with `v502-1` (and click save) - [x] Update installation date with 8d ago (and click save) - [x] Close the app, open it again (or fire button) - [x] Ensure `Fired pixel user_retention_week with params {count=2}` - [x] Update app retention atb with `v502-1` (and click save) - [x] Update installation date with 1mo ago (and click save) - [x] Close the app, open it again (or fire button) - [x] Ensure `Fired pixel user_retention_month with params {count=1}` ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
7f507c3
into
feature/cristian/attributed_metrics_internal_dev_settings
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175158?focus=true
and: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175159?focus=true
Description
Introduces 2 attributed metrics and their initial implementation.
Steps to test this PR
While testing this PR you need to add the following in your logcat filter:
tag~:"AttributedMetrics"Note: Test cases should be executed in order
Not enough data
Client status running: true -> isActive: true, isEnabled: trueAttributed Metrics Dev Settingsv502-1(and click save)v502-1(and click save)SearchCount7d: Skip emitting, atb not changedSending data
Attributed Metrics Dev Settingsv502-1(and click save)v502-1(and click save)Fired pixel user_average_searches_past_week_first_month with params {count=0}(Note: 0 is the bucket, not value. Notice first_month in pixel name)Fired pixel user_active_past_week with params {days=2}(note: 2 is the bucket, not the value)Trigger only if search atb refreshes
SearchCount7d: Skip emitting, atb not changedddg_search_daysandddg_search)Trigger only if app retention atb refreshes
SearchDays: Skip emitting atb not changed)installation >1mo ago
Attributed Metrics Dev Settingsv402-1(and click save)v402-1(and click save)Fired pixel user_average_searches_past_week with params {count=0}(Note: 0 is the bucket, not value. Notice this is not first_month)Fired pixel user_active_past_week with params {days=2}(note: 2 is the bucket, not the value)Client not active
Client status running: false -> isActive: false, isEnabled: trueDiscard collect event....client not activeUI changes