Skip to content

Fix IllegalStateException when closing Duck.ai #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Fix IllegalStateException when closing Duck.ai #6839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,9 +840,11 @@ open class BrowserActivity : DuckDuckGoActivity() {
val fragment = duckAiFragment
if (fragment?.isVisible == true) {
animateDuckAiFragmentOut {
val transaction = supportFragmentManager.beginTransaction()
transaction.hide(fragment)
transaction.commit()
if (!supportFragmentManager.isStateSaved) {
Copy link
Contributor

@LukasPaczos LukasPaczos Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how exactly that scenario would play out, but shouldn't this be checked before we run any logic in the function? Otherwise, if a state is restored with fragment visible, our local isDuckChatVisible would be set to false already.

Copy link
Contributor Author

@joshliebe joshliebe Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be checked when the animation completes, if we check it before, the state may have changed by then. Not sure how to deal with that inconsistency.

Copy link
Contributor

@LukasPaczos LukasPaczos Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Anyway, looks like a quick way to prevent the crash and worst case we'll have a one time issue with keyboard pop-up which will resolve itself either way, so that's not a big deal.

val transaction = supportFragmentManager.beginTransaction()
transaction.hide(fragment)
transaction.commit()
}
}
}
}
Expand Down
Loading