Fix IllegalStateException when closing Duck.ai #6839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Sep 24, 2025
| val transaction = supportFragmentManager.beginTransaction() | ||
| transaction.hide(fragment) | ||
| transaction.commit() | ||
| if (!supportFragmentManager.isStateSaved) { |
Contributor
There was a problem hiding this comment.
I'm not sure how exactly that scenario would play out, but shouldn't this be checked before we run any logic in the function? Otherwise, if a state is restored with fragment visible, our local isDuckChatVisible would be set to false already.
Contributor
Author
There was a problem hiding this comment.
It needs to be checked when the animation completes, if we check it before, the state may have changed by then. Not sure how to deal with that inconsistency.
Contributor
There was a problem hiding this comment.
Right. Anyway, looks like a quick way to prevent the crash and worst case we'll have a one time issue with keyboard pop-up which will resolve itself either way, so that's not a big deal.
LukasPaczos
approved these changes
Sep 24, 2025
| val transaction = supportFragmentManager.beginTransaction() | ||
| transaction.hide(fragment) | ||
| transaction.commit() | ||
| if (!supportFragmentManager.isStateSaved) { |
Contributor
There was a problem hiding this comment.
Right. Anyway, looks like a quick way to prevent the crash and worst case we'll have a one time issue with keyboard pop-up which will resolve itself either way, so that's not a big deal.
LukasPaczos
added a commit
that referenced
this pull request
Sep 25, 2025
This reverts commit ec6e5e5.
6 tasks
joshliebe
pushed a commit
that referenced
this pull request
Sep 26, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1211468322303343?focus=true ### Description Fixes an issue with inaccessible Duck.ai fragment that could happen after failed fragment state transaction. If the Duck.ai close transition finished after `onSaveInstanceState`, the fragment container would be hidden but the fragment itself wouldn't. This led to an invalid state where the app thought the fragment was visible, preventing it from ever re-launching, but its container was `gone`. To resolve the issue, this PR: 1. Allows for lossy fragment transaction when closing Duck.ai. This resolves any potential crashes that #6839 attempted to fix. 2. Checks for fragment and its container state consistency when trying to open Duck.ai. This prevents any state locks in rare cases where activity is restored from saved state after being in Duck.ai mode. ### Steps to test this PR The issue was mostly reproducible for me in `release` variant and with Input Screen enabled, because on New Tab Page the Input Screen reopens after closing Duck.ai fragment which has a higher likelihood of canceling the transitions. - [x] Enable Input Screen. - [x] Open New Tab Page. - [x] Open Input Screen. - [x] Send a prompt to Duck.ai. - [x] Go back and reopen the Input Screen. - [x] Send another prompt to Duck.ai and verify it correctly opens.
karlenDimla
pushed a commit
that referenced
this pull request
Sep 26, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211438741846582?focus=true ### Description - Checks `supportFragmentManager.isStateSaved` once the transition has completed to avoid `IllegalStateException` ### Steps to test this PR - [ ] Open Duck.ai - [ ] Close Duck.ai - [ ] Verify that the fragment animates out and hides
karlenDimla
pushed a commit
that referenced
this pull request
Sep 26, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1211468322303343?focus=true ### Description Fixes an issue with inaccessible Duck.ai fragment that could happen after failed fragment state transaction. If the Duck.ai close transition finished after `onSaveInstanceState`, the fragment container would be hidden but the fragment itself wouldn't. This led to an invalid state where the app thought the fragment was visible, preventing it from ever re-launching, but its container was `gone`. To resolve the issue, this PR: 1. Allows for lossy fragment transaction when closing Duck.ai. This resolves any potential crashes that #6839 attempted to fix. 2. Checks for fragment and its container state consistency when trying to open Duck.ai. This prevents any state locks in rare cases where activity is restored from saved state after being in Duck.ai mode. ### Steps to test this PR The issue was mostly reproducible for me in `release` variant and with Input Screen enabled, because on New Tab Page the Input Screen reopens after closing Duck.ai fragment which has a higher likelihood of canceling the transitions. - [x] Enable Input Screen. - [x] Open New Tab Page. - [x] Open Input Screen. - [x] Send a prompt to Duck.ai. - [x] Go back and reopen the Input Screen. - [x] Send another prompt to Duck.ai and verify it correctly opens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211438741846582?focus=true
Description
supportFragmentManager.isStateSavedonce the transition has completed to avoidIllegalStateExceptionSteps to test this PR