Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aura experiment #5343

Merged
merged 16 commits into from
Dec 9, 2024
Merged

Add Aura experiment #5343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7c3df85
Add Aura experiment
joshliebe Dec 4, 2024
605ab51
Update string
joshliebe Dec 4, 2024
695306a
Fix issues
joshliebe Dec 4, 2024
86ace43
Fix lint issue
joshliebe Dec 4, 2024
70c4f2f
Remove unused import
joshliebe Dec 4, 2024
ae8658c
Comment public interfaces
joshliebe Dec 4, 2024
68ddd17
Fix test
joshliebe Dec 4, 2024
b911d7c
Adjust to use AppBuildConfig.isAppReinstall and AtbInitializer
joshliebe Dec 6, 2024
2f9446a
Add withContext to parseJson
joshliebe Dec 6, 2024
fb938df
Fix StubStatisticsModule
joshliebe Dec 6, 2024
73aeb7a
Update reinstall checking logic
joshliebe Dec 6, 2024
7fed0f2
Fix ReinstallAtbListenerTest
joshliebe Dec 6, 2024
fa2b93d
Fix lint issue
joshliebe Dec 6, 2024
7e434fe
Rename AuraExperimentManagerImpl to AuraExperimentManager
joshliebe Dec 6, 2024
bcffa4c
Address PR comments
joshliebe Dec 9, 2024
ca75904
Remove unnecessary reinstall check
joshliebe Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comment public interfaces
  • Loading branch information
@joshliebe
joshliebe committed Dec 4, 2024
commit ae8658c2e1df715644228543073917b589a6df71
2 changes: 1 addition & 1 deletion app/src/main/java/com/duckduckgo/app/browser/aura/AuraExperimentManagerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import com.duckduckgo.app.aura.AuraExperimentManager
import com.duckduckgo.app.referral.AppReferrerDataStore
import com.duckduckgo.app.statistics.store.StatisticsDataStore
import com.duckduckgo.di.scopes.AppScope
import com.duckduckgo.installation.impl.installer.InstallSourceExtractor
import com.duckduckgo.installation.api.installer.InstallSourceExtractor
import com.squareup.anvil.annotations.ContributesBinding
import dagger.SingleInstanceIn
import javax.inject.Inject
Expand Down
2 changes: 1 addition & 1 deletion app/src/test/java/com/duckduckgo/app/browser/aura/AuraExperimentManagerImplTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package com.duckduckgo.app.browser.aura
import com.duckduckgo.app.referral.AppReferrerDataStore
import com.duckduckgo.app.statistics.store.StatisticsDataStore
import com.duckduckgo.feature.toggles.api.Toggle
import com.duckduckgo.installation.impl.installer.InstallSourceExtractor
import com.duckduckgo.installation.api.installer.InstallSourceExtractor
import kotlinx.coroutines.test.runTest
import org.junit.Before
import org.junit.Test
Expand Down
6 changes: 6 additions & 0 deletions browser-api/src/main/java/com/duckduckgo/app/aura/AuraExperimentManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@

package com.duckduckgo.app.aura

/** Public interface for AuraExperimentManagerImpl */
interface AuraExperimentManager {

/**
* Initializes the AuraExperimentManager.
* This checks if the install source is an Aura package, setting the ATB variant and origin accordingly.
*/
joshliebe marked this conversation as resolved.
Show resolved Hide resolved
suspend fun initialize()
}
7 changes: 6 additions & 1 deletion .../impl/installer/InstallSourceExtractor.kt → ...n/api/installer/InstallSourceExtractor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@
* limitations under the License.
*/

package com.duckduckgo.installation.impl.installer
package com.duckduckgo.installation.api.installer

/** Public interface for RealInstallSourceExtractor */
joshliebe marked this conversation as resolved.
Show resolved Hide resolved
interface InstallSourceExtractor {
joshliebe marked this conversation as resolved.
Show resolved Hide resolved

/**
* Extracts the installer package name from the PackageManager.
*/
fun extract(): String?
}
1 change: 1 addition & 0 deletions ...ain/java/com/duckduckgo/installation/impl/installer/InstallSourcePrivacyConfigObserver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import com.duckduckgo.common.utils.DispatcherProvider
import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin
import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin.PixelParameter
import com.duckduckgo.di.scopes.AppScope
import com.duckduckgo.installation.api.installer.InstallSourceExtractor
import com.duckduckgo.installation.impl.installer.InstallationPixelName.APP_INSTALLER_FULL_PACKAGE_NAME
import com.duckduckgo.installation.impl.installer.InstallationPixelName.APP_INSTALLER_PACKAGE_NAME
import com.duckduckgo.installation.impl.installer.fullpackage.InstallSourceFullPackageStore
Expand Down
1 change: 1 addition & 0 deletions ...pl/src/main/java/com/duckduckgo/installation/impl/installer/RealInstallSourceExtractor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import android.content.Context
import androidx.annotation.RequiresApi
import com.duckduckgo.appbuildconfig.api.AppBuildConfig
import com.duckduckgo.di.scopes.AppScope
import com.duckduckgo.installation.api.installer.InstallSourceExtractor
import com.squareup.anvil.annotations.ContributesBinding
import javax.inject.Inject

Expand Down
Loading