-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aura experiment #5343
Add Aura experiment #5343
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working well! a few nit/suggestions, but overall LGTM
app/src/main/java/com/duckduckgo/app/browser/aura/AuraExperimentListJsonParser.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/aura/AuraExperimentManagerImpl.kt
Outdated
Show resolved
Hide resolved
browser-api/src/main/java/com/duckduckgo/app/aura/AuraExperimentManager.kt
Outdated
Show resolved
Hide resolved
...lation-api/src/main/java/com/duckduckgo/installation/api/installer/InstallSourceExtractor.kt
Outdated
Show resolved
Hide resolved
statistics/statistics-impl/src/main/java/com/duckduckgo/app/statistics/AtbInitializer.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we don't need to add code outside the install-impl package. Unless I miss something, everything can just be an implementation detail. No need to add the install-api neither add anything in the :app module
app/src/main/java/com/duckduckgo/app/referral/AppReferrerDataStore.kt
Outdated
Show resolved
Hide resolved
...lation-api/src/main/java/com/duckduckgo/installation/api/installer/InstallSourceExtractor.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/aura/AuraExperimentManagerImpl.kt
Outdated
Show resolved
Hide resolved
we'll discuss but no need to block review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New approach tested and again, and still working as expected.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208893765398547/f
Description
Sets the ATB variant and origin for Aura installs in order to measure retention.
Steps to test this PR
Point at the JSON Blob linked in the task
Feature enabled and new user Aura install
installationSourceModern()
inRealInstallSourceExtractor
to return an Aura package (e.g.com.sec.android.app.samsungapps
)Initialized ATB
mq
m_android_install
origin=funnel_app_aurapaid_android
reinstall=false
Feature enabled and returning user Aura install
Initialized ATB
mq
m_android_install
origin=funnel_app_aurapaid_android
reinstall=true
Feature disabled and new user Aura install
auraExperiment
in the configInitialized ATB
mq
)m_android_install
origin=funnel_app_aurapaid_android
is not sentreinstall=false
Feature disabled and returning user Aura install
Initialized ATB
mq
)m_android_install
origin=funnel_app_aurapaid_android
is not sentreinstall=true
Feature enabled and new user install (Not Aura)
auraExperiment
in the configinstallationSourceModern()
inRealInstallSourceExtractor
to return something else (e.g.com.example
)Initialized ATB
mq
)m_android_install
origin=funnel_app_aurapaid_android
is not sentreinstall=false
Feature enabled and returning user install (Not Aura)
Initialized ATB
mq
)m_android_install
origin=funnel_app_aurapaid_android
is not sentreinstall=true