Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aura experiment #5343

Merged
merged 16 commits into from
Dec 9, 2024
Merged

Add Aura experiment #5343

merged 16 commits into from
Dec 9, 2024

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Dec 4, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1208893765398547/f

Description

Sets the ATB variant and origin for Aura installs in order to measure retention.

Steps to test this PR

Point at the JSON Blob linked in the task

Feature enabled and new user Aura install

  • Check out this branch
  • Change installationSourceModern() in RealInstallSourceExtractor to return an Aura package (e.g. com.sec.android.app.samsungapps)
  • On a fresh emulator, freshly install the app
  • Filter logcat by Initialized ATB
  • Verify that the variant is mq
  • Filter logcat by m_android_install
  • Verify that origin=funnel_app_aurapaid_android
  • Verify that reinstall=false

Feature enabled and returning user Aura install

  • On the same emulator, uninstall and freshly install the app
  • Filter logcat by Initialized ATB
  • Verify that the variant is mq
  • Filter logcat by m_android_install
  • Verify that origin=funnel_app_aurapaid_android
  • Verify that reinstall=true

Feature disabled and new user Aura install

  • Disable auraExperiment in the config
  • On a fresh emulator, freshly install the app
  • Filter logcat by Initialized ATB
  • Verify that the variant is set normally (Not mq)
  • Filter logcat by m_android_install
  • Verify that origin=funnel_app_aurapaid_android is not sent
  • Verify that reinstall=false

Feature disabled and returning user Aura install

  • On the same emulator, uninstall and freshly install the app
  • Filter logcat by Initialized ATB
  • Verify that the variant is set normally (Not mq)
  • Filter logcat by m_android_install
  • Verify that origin=funnel_app_aurapaid_android is not sent
  • Verify that reinstall=true

Feature enabled and new user install (Not Aura)

  • Re-enable auraExperiment in the config
  • Change installationSourceModern() in RealInstallSourceExtractor to return something else (e.g. com.example)
  • On a fresh emulator, freshly install the app
  • Filter logcat by Initialized ATB
  • Verify that the variant is set normally (Not mq)
  • Filter logcat by m_android_install
  • Verify that origin=funnel_app_aurapaid_android is not sent
  • Verify that reinstall=false

Feature enabled and returning user install (Not Aura)

  • On the same emulator, uninstall and freshly install the app
  • Filter logcat by Initialized ATB
  • Verify that the variant is set normally (Not mq)
  • Filter logcat by m_android_install
  • Verify that origin=funnel_app_aurapaid_android is not sent
  • Verify that reinstall=true

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well! a few nit/suggestions, but overall LGTM

Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we don't need to add code outside the install-impl package. Unless I miss something, everything can just be an implementation detail. No need to add the install-api neither add anything in the :app module

@aitorvs aitorvs dismissed their stale review December 6, 2024 08:33

we'll discuss but no need to block review

Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New approach tested and again, and still working as expected.

@joshliebe joshliebe merged commit 503911f into develop Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants