Skip to content

Ensure credential list items don't have their text clipped #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Feb 8, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1203911394442538/f

Description

Ensures the title text in the credential management list view doesn't get clipped when text size is larger

Steps to test this PR

QA-optional, but if you want to test:

  • Increase font size on device and visit credential management screen
  • Ensure you have a site with a descender in the title (e.g., google.com)
  • Verify the descender is visible

@CDRussell
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@CDRussell CDRussell marked this pull request as ready for review February 8, 2023 14:38
@marcosholgado marcosholgado self-requested a review February 9, 2023 09:10
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CDRussell CDRussell merged commit 4a530c1 into develop Feb 9, 2023
@CDRussell CDRussell deleted the feature/craig/autofill_fix_text_clipping_on_list_view branch February 9, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants