Skip to content

Commit 4a530c1

Browse files
authored
Ensure credential list items don't have their text clipped (#2825)
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) 3. Make sure these changes are tested in API 23 and API 26 If your PR does not involve UI changes, you can remove the **UI changes** section --> Task/Issue URL: https://app.asana.com/0/488551667048375/1203911394442538/f ### Description Ensures the title text in the credential management list view doesn't get clipped when text size is larger ### Steps to test this PR QA-optional, but if you want to test: - [x] Increase font size on device and visit credential management screen - [x] Ensure you have a site with a descender in the title (e.g., `google.com`) - [x] Verify the descender is visible
1 parent 194c9b8 commit 4a530c1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

autofill/autofill-impl/src/main/res/layout/item_row_autofill_credentials_management_screen.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
tools:ignore="DeprecatedWidgetInXml"
4040
android:id="@+id/title"
4141
android:layout_width="0dp"
42-
android:layout_height="0dp"
42+
android:layout_height="wrap_content"
4343
tools:text="duckduckgo.com"
4444
android:textColor="?daxColorPrimaryText"
4545
android:textSize="16sp"

0 commit comments

Comments
 (0)