Skip to content

Commit

Permalink
Ensure credential list items don't have their text clipped (#2825)
Browse files Browse the repository at this point in the history
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
    3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->

Task/Issue URL:
https://app.asana.com/0/488551667048375/1203911394442538/f

### Description
Ensures the title text in the credential management list view doesn't
get clipped when text size is larger

### Steps to test this PR
QA-optional, but if you want to test:
- [x] Increase font size on device and visit credential management
screen
- [x] Ensure you have a site with a descender in the title (e.g.,
`google.com`)
- [x] Verify the descender is visible
  • Loading branch information
CDRussell authored Feb 9, 2023
1 parent 194c9b8 commit 4a530c1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
tools:ignore="DeprecatedWidgetInXml"
android:id="@+id/title"
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_height="wrap_content"
tools:text="duckduckgo.com"
android:textColor="?daxColorPrimaryText"
android:textSize="16sp"
Expand Down

0 comments on commit 4a530c1

Please sign in to comment.