Improve feature toggle API to actually use default value

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt

@@ -3945,7 +3945,7 @@ class BrowserTabViewModelTest {
 
     private fun givenUrlCannotUseGpc(url: String) {
         val exceptions = CopyOnWriteArrayList<GpcException>().apply { add(GpcException(url)) }
-        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName()), any())).thenReturn(true)
+        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName), any())).thenReturn(true)
         whenever(mockGpcRepository.isGpcEnabled()).thenReturn(true)
         whenever(mockGpcRepository.exceptions).thenReturn(exceptions)
     }

app/src/androidTest/java/com/duckduckgo/app/email/EmailInjectorJsTest.kt

@@ -43,7 +43,7 @@ class EmailInjectorJsTest {
     fun setup() {
         testee = EmailInjectorJs(mockEmailManager, DuckDuckGoUrlDetector(), mockDispatcherProvider, mockFeatureToggle, mockAutofill)
 
-        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName())).thenReturn(true)
+        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName)).thenReturn(true)
         whenever(mockAutofill.isAnException(any())).thenReturn(false)
     }
 
@@ -102,7 +102,7 @@ class EmailInjectorJsTest {
     @SdkSuppress(minSdkVersion = 24)
     fun whenInjectEmailAutofillJsAndUrlIsFromDuckDuckGoAndFeatureIsDisabledThenInjectJsCode() {
         whenever(mockEmailManager.isSignedIn()).thenReturn(true)
-        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName())).thenReturn(false)
+        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName)).thenReturn(false)
 
         val jsToEvaluate = getJsToEvaluate()
         val webView = spy(WebView(InstrumentationRegistry.getInstrumentation().targetContext))
@@ -144,7 +144,7 @@ class EmailInjectorJsTest {
     @Test
     @SdkSuppress(minSdkVersion = 24)
     fun whenInjectAddressAndFeatureIsDisabledThenJsCodeNotInjected() {
-        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName())).thenReturn(false)
+        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName)).thenReturn(false)
 
         val address = "address"
         val webView = spy(WebView(InstrumentationRegistry.getInstrumentation().targetContext))

app/src/androidTest/java/com/duckduckgo/app/httpsupgrade/HttpsUpgraderTest.kt

@@ -44,14 +44,14 @@ class HttpsUpgraderTest {
     @Before
     fun before() {
         whenever(mockHttpsBloomFilterFactory.create()).thenReturn(bloomFilter)
-        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName())).thenReturn(true)
+        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName)).thenReturn(true)
         testee = HttpsUpgraderImpl(mockHttpsBloomFilterFactory, mockBloomFalsePositiveListDao, mockUserAllowlistDao, mockFeatureToggle, mockHttps)
         testee.reloadData()
     }
 
     @Test
     fun whenFeatureIsDisableTheShouldNotUpgrade() {
-        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName())).thenReturn(false)
+        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName)).thenReturn(false)
         bloomFilter.add("www.local.url")
         assertFalse(testee.shouldUpgrade(Uri.parse("http://www.local.url")))
     }

app/src/androidTest/java/com/duckduckgo/app/integration/HttpsEmbeddedDataIntegrationTest.kt

@@ -53,7 +53,7 @@ class HttpsEmbeddedDataIntegrationTest {
 
     @Before
     fun before() {
-        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName())).thenReturn(true)
+        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName)).thenReturn(true)
 
         db = Room.inMemoryDatabaseBuilder(context, AppDatabase::class.java)
             .allowMainThreadQueries()

app/src/androidTest/java/com/duckduckgo/app/referencetests/HttpsReferenceTest.kt

@@ -167,7 +167,7 @@ class HttpsReferenceTest(private val testCase: TestCase) {
         val isEnabled = httpsFeature?.state == "enabled"
         val exceptionsUnprotectedTemporary = CopyOnWriteArrayList(config?.unprotectedTemporary ?: emptyList())
 
-        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName(), isEnabled)).thenReturn(isEnabled)
+        whenever(mockFeatureToggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName, isEnabled)).thenReturn(isEnabled)
         whenever(mockHttpsRepository.exceptions).thenReturn(CopyOnWriteArrayList(httpsExceptions))
         whenever(mockUnprotectedTemporaryRepository.exceptions).thenReturn(exceptionsUnprotectedTemporary)
 

app/src/main/java/com/duckduckgo/app/brokensite/api/BrokenSiteSender.kt

@@ -50,7 +50,7 @@ class BrokenSiteSubmitter(
 ) : BrokenSiteSender {
 
     override fun submitBrokenSiteFeedback(brokenSite: BrokenSite) {
-        val isGpcEnabled = (featureToggle.isFeatureEnabled(PrivacyFeatureName.GpcFeatureName()) == true && gpc.isEnabled()).toString()
+        val isGpcEnabled = (featureToggle.isFeatureEnabled(PrivacyFeatureName.GpcFeatureName) == true && gpc.isEnabled()).toString()
         val absoluteUrl = Uri.parse(brokenSite.siteUrl).absoluteString
 
         appCoroutineScope.launch(dispatcherProvider.io()) {

app/src/main/java/com/duckduckgo/app/email/EmailInjector.kt

@@ -91,7 +91,7 @@ class EmailInjectorJs(
         }
     }
 
-    private fun isFeatureEnabled() = featureToggle.isFeatureEnabled(PrivacyFeatureName.AutofillFeatureName(), defaultValue = true) ?: false
+    private fun isFeatureEnabled() = featureToggle.isFeatureEnabled(PrivacyFeatureName.AutofillFeatureName, defaultValue = true)
 
     private fun isDuckDuckGoUrl(url: String?): Boolean = (url != null && urlDetector.isDuckDuckGoEmailUrl(url))
 

app/src/main/java/com/duckduckgo/app/email/EmailJavascriptInterface.kt

@@ -46,7 +46,7 @@ class EmailJavascriptInterface(
         return (url != null && urlDetector.isDuckDuckGoEmailUrl(url))
     }
 
-    private fun isFeatureEnabled() = featureToggle.isFeatureEnabled(PrivacyFeatureName.AutofillFeatureName(), defaultValue = true) ?: false
+    private fun isFeatureEnabled() = featureToggle.isFeatureEnabled(PrivacyFeatureName.AutofillFeatureName, defaultValue = true)
 
     @JavascriptInterface
     fun isSignedIn(): String {

app/src/main/java/com/duckduckgo/app/globalprivacycontrol/ui/GlobalPrivacyControlViewModel.kt

@@ -53,7 +53,7 @@ class GlobalPrivacyControlViewModel(
     init {
         _viewState.value = ViewState(
             globalPrivacyControlEnabled = gpc.isEnabled(),
-            globalPrivacyControlFeatureEnabled = featureToggle.isFeatureEnabled(PrivacyFeatureName.GpcFeatureName(), true) == true
+            globalPrivacyControlFeatureEnabled = featureToggle.isFeatureEnabled(PrivacyFeatureName.GpcFeatureName, true) == true
         )
         pixel.fire(SETTINGS_DO_NOT_SELL_SHOWN)
     }

app/src/main/java/com/duckduckgo/app/httpsupgrade/HttpsUpgrader.kt

@@ -78,7 +78,7 @@ class HttpsUpgraderImpl @Inject constructor(
     override fun shouldUpgrade(uri: Uri): Boolean {
         val host = uri.host ?: return false
 
-        if (toggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName()) != true) {
+        if (toggle.isFeatureEnabled(PrivacyFeatureName.HttpsFeatureName) != true) {
             Timber.d("https is disabled in the remote config and so $host is not upgradable")
             return false
         }

app/src/main/java/com/duckduckgo/app/settings/SettingsViewModel.kt

@@ -149,7 +149,7 @@ class SettingsViewModel(
                     automaticallyClearData = AutomaticallyClearData(automaticallyClearWhat, automaticallyClearWhen, automaticallyClearWhenEnabled),
                     appIcon = settingsDataStore.appIcon,
                     selectedFireAnimation = settingsDataStore.selectedFireAnimation,
-                    globalPrivacyControlEnabled = gpc.isEnabled() && featureToggle.isFeatureEnabled(PrivacyFeatureName.GpcFeatureName()) == true,
+                    globalPrivacyControlEnabled = gpc.isEnabled() && featureToggle.isFeatureEnabled(PrivacyFeatureName.GpcFeatureName) == true,
                     appLinksSettingType = getAppLinksSettingsState(settingsDataStore.appLinksEnabled, settingsDataStore.showAppLinksPrompt),
                     appTrackingProtectionEnabled = TrackerBlockingVpnService.isServiceRunning(appContext),
                     appTrackingProtectionWaitlistState = atpRepository.getState()

app/src/test/java/com/duckduckgo/app/email/EmailJavascriptInterfaceTest.kt

@@ -60,7 +60,7 @@ class EmailJavascriptInterfaceTest {
             mockAutofill
         ) { counter++ }
 
-        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName())).thenReturn(true)
+        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName)).thenReturn(true)
         whenever(mockAutofill.isAnException(any())).thenReturn(false)
     }
 
@@ -130,7 +130,7 @@ class EmailJavascriptInterfaceTest {
     @Test
     fun whenShowTooltipAndFeatureDisabledThenLambdaNotCalled() {
         whenever(mockWebView.url).thenReturn(NON_EMAIL_URL)
-        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName())).thenReturn(false)
+        whenever(mockFeatureToggle.isFeatureEnabled(AutofillFeatureName)).thenReturn(false)
 
         testee.showTooltip()
 

app/src/test/java/com/duckduckgo/app/settings/SettingsViewModelTest.kt

@@ -139,7 +139,7 @@ class SettingsViewModelTest {
 
     @Test
     fun whenStartIfGpcToggleDisabledAndGpcEnabledThenGpgDisabled() = runTest {
-        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName()), any())).thenReturn(false)
+        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName), any())).thenReturn(false)
         whenever(mockGpc.isEnabled()).thenReturn(true)
 
         testee.start()
@@ -152,7 +152,7 @@ class SettingsViewModelTest {
 
     @Test
     fun whenStartIfGpcToggleEnabledAndGpcDisabledThenGpgDisabled() = runTest {
-        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName()), any())).thenReturn(true)
+        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName), any())).thenReturn(true)
         whenever(mockGpc.isEnabled()).thenReturn(false)
         testee.start()
 
@@ -164,7 +164,7 @@ class SettingsViewModelTest {
 
     @Test
     fun whenStartIfGpcToggleEnabledAndGpcEnabledThenGpgEnabled() = runTest {
-        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName()), any())).thenReturn(true)
+        whenever(mockFeatureToggle.isFeatureEnabled(eq(PrivacyFeatureName.GpcFeatureName), any())).thenReturn(true)
         whenever(mockGpc.isEnabled()).thenReturn(true)
         testee.start()
 

feature-toggles/feature-toggles-api/src/main/java/com/duckduckgo/feature/toggles/api/FeatureToggle.kt

@@ -20,13 +20,13 @@ package com.duckduckgo.feature.toggles.api
 interface FeatureToggle {
     /**
      * This method takes a [featureName] and optionally a default value.
-     * @return `true` if the feature is enabled, `false` if is not and `null` if the feature does
-     * not exist.
+     * @return `true` if the feature is enabled, `false` if is not
+     * @throws [IllegalArgumentException] if the feature is not implemented
      */
     fun isFeatureEnabled(
         featureName: FeatureName,
         defaultValue: Boolean = true
-    ): Boolean?
+    ): Boolean
 }
 
 /**

feature-toggles/feature-toggles-impl/src/main/java/com/duckduckgo/feature/toggles/impl/RealFeatureTogglesImpl.kt

@@ -34,11 +34,12 @@ class RealFeatureToggleImpl @Inject constructor(private val featureTogglesPlugin
     override fun isFeatureEnabled(
         featureName: FeatureName,
         defaultValue: Boolean
-    ): Boolean? {
+    ): Boolean {
         featureTogglesPluginPoint.getPlugins().forEach { plugin ->
             plugin.isEnabled(featureName, defaultValue)?.let { return it }
         }
-        return null
+
+        throw IllegalArgumentException("Unknown feature: ${featureName.value}")
     }
 }
 

feature-toggles/feature-toggles-impl/src/test/java/com/duckduckgo/feature/toggles/impl/RealFeatureToggleImplTest.kt

@@ -31,10 +31,10 @@ class RealFeatureToggleImplTest {
     fun whenFeatureNameCanBeHandledByPluginThenReturnTheCorrectValue() {
         val result = testee.isFeatureEnabled(TrueFeatureName(), false)
         assertNotNull(result)
-        assertTrue(result!!)
+        assertTrue(result)
     }
 
-    @Test
+    @Test(expected = IllegalArgumentException::class)
     fun whenFeatureNameCannotBeHandledByAnyPluginThenReturnNull() {
         val result = testee.isFeatureEnabled(NullFeatureName(), false)
         assertNull(result)

privacy-config/privacy-config-api/src/main/java/com/duckduckgo/privacy/config/api/PrivacyFeatureName.kt

@@ -19,20 +19,20 @@ package com.duckduckgo.privacy.config.api
 import com.duckduckgo.feature.toggles.api.FeatureName
 
 /** List of [FeatureName] that belong to the Privacy Configuration */
-sealed class PrivacyFeatureName(override val value: String) : FeatureName {
-    data class ContentBlockingFeatureName(override val value: String = "contentBlocking") :
-        PrivacyFeatureName(value)
-
-    data class GpcFeatureName(override val value: String = "gpc") : PrivacyFeatureName(value)
-    data class HttpsFeatureName(override val value: String = "https") : PrivacyFeatureName(value)
-    data class TrackerAllowlistFeatureName(override val value: String = "trackerAllowlist") :
-        PrivacyFeatureName(value)
-
-    data class DrmFeatureName(override val value: String = "eme") : PrivacyFeatureName(value)
-    data class AmpLinksFeatureName(override val value: String = "ampLinks") :
-        PrivacyFeatureName(value)
+enum class PrivacyFeatureName(override val value: String) : FeatureName {
+    ContentBlockingFeatureName("contentBlocking"),
+    GpcFeatureName("gpc"),
+    HttpsFeatureName("https"),
+    TrackerAllowlistFeatureName("trackerAllowlist"),
+    DrmFeatureName("eme"),
+    AmpLinksFeatureName("ampLinks"),
+    TrackingParametersFeatureName("trackingParameters"),
+    AutofillFeatureName("autofill"),
+}
 
-    data class TrackingParametersFeatureName(override val value: String = "trackingParameters") :
-        PrivacyFeatureName(value)
-    data class AutofillFeatureName(override val value: String = "autofill") : PrivacyFeatureName(value)
+/**
+ * Convenience method to get the [PrivacyFeatureName] from its [String] value
+ */
+fun privacyFeatureValueOf(value: String): PrivacyFeatureName? {
+    return PrivacyFeatureName.values().find { it.value == value }
 }

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/PrivacyConfigPersister.kt

@@ -19,6 +19,7 @@ package com.duckduckgo.privacy.config.impl
 import androidx.annotation.WorkerThread
 import com.duckduckgo.app.global.plugins.PluginPoint
 import com.duckduckgo.di.scopes.AppScope
+import com.duckduckgo.privacy.config.api.privacyFeatureValueOf
 import com.duckduckgo.privacy.config.impl.models.JsonPrivacyConfig
 import com.duckduckgo.privacy.config.impl.plugins.PrivacyFeaturePlugin
 import com.duckduckgo.privacy.config.store.PrivacyConfig
@@ -58,7 +59,9 @@ class RealPrivacyConfigPersister @Inject constructor(
                 jsonPrivacyConfig.features.forEach { feature ->
                     feature.value?.let { jsonObject ->
                         privacyFeaturePluginPoint.getPlugins().forEach { plugin ->
-                            plugin.store(feature.key, jsonObject.toString())
+                            privacyFeatureValueOf(feature.key)?.let {
+                                plugin.store(it, jsonObject.toString())
+                            }
                         }
                     }
                 }

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/amplinks/AmpLinksPlugin.kt

@@ -32,8 +32,8 @@ class AmpLinksPlugin @Inject constructor(
     private val privacyFeatureTogglesRepository: PrivacyFeatureTogglesRepository
 ) : PrivacyFeaturePlugin {
 
-    override fun store(name: String, jsonString: String): Boolean {
-        if (name == featureName.value) {
+    override fun store(name: PrivacyFeatureName, jsonString: String): Boolean {
+        if (name == featureName) {
             val moshi = Moshi.Builder().build()
             val jsonAdapter: JsonAdapter<AmpLinksFeature> =
                 moshi.adapter(AmpLinksFeature::class.java)
@@ -64,5 +64,5 @@ class AmpLinksPlugin @Inject constructor(
         return false
     }
 
-    override val featureName: PrivacyFeatureName = PrivacyFeatureName.AmpLinksFeatureName()
+    override val featureName: PrivacyFeatureName = PrivacyFeatureName.AmpLinksFeatureName
 }

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/amplinks/RealAmpLinks.kt

@@ -50,7 +50,7 @@ class RealAmpLinks @Inject constructor(
     }
 
     override fun extractCanonicalFromAmpLink(url: String): AmpLinkType? {
-        if (featureToggle.isFeatureEnabled(PrivacyFeatureName.AmpLinksFeatureName()) == false) return null
+        if (featureToggle.isFeatureEnabled(PrivacyFeatureName.AmpLinksFeatureName) == false) return null
         if (url == lastExtractedUrl) return null
 
         val extractedUrl = extractCanonical(url)

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/autofill/AutofillPlugin.kt

@@ -35,10 +35,10 @@ class AutofillPlugin @Inject constructor(
 ) : PrivacyFeaturePlugin {
 
     override fun store(
-        name: String,
+        name: PrivacyFeatureName,
         jsonString: String
     ): Boolean {
-        if (name == featureName.value) {
+        if (name == featureName) {
             val autofillExceptions = mutableListOf<AutofillExceptionEntity>()
             val moshi = Moshi.Builder().build()
             val jsonAdapter: JsonAdapter<AutofillFeature> =
@@ -56,5 +56,5 @@ class AutofillPlugin @Inject constructor(
         return false
     }
 
-    override val featureName: PrivacyFeatureName = PrivacyFeatureName.AutofillFeatureName()
+    override val featureName: PrivacyFeatureName = PrivacyFeatureName.AutofillFeatureName
 }

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/contentblocking/ContentBlockingPlugin.kt

@@ -35,10 +35,10 @@ class ContentBlockingPlugin @Inject constructor(
 ) : PrivacyFeaturePlugin {
 
     override fun store(
-        name: String,
+        name: PrivacyFeatureName,
         jsonString: String
     ): Boolean {
-        if (name == featureName.value) {
+        if (name == featureName) {
             val contentBlockingExceptions = mutableListOf<ContentBlockingExceptionEntity>()
             val moshi = Moshi.Builder().build()
             val jsonAdapter: JsonAdapter<ContentBlockingFeature> =
@@ -56,5 +56,5 @@ class ContentBlockingPlugin @Inject constructor(
         return false
     }
 
-    override val featureName: PrivacyFeatureName = PrivacyFeatureName.ContentBlockingFeatureName()
+    override val featureName: PrivacyFeatureName = PrivacyFeatureName.ContentBlockingFeatureName
 }

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/contentblocking/RealContentBlocking.kt

@@ -36,7 +36,7 @@ class RealContentBlocking @Inject constructor(
 ) : ContentBlocking {
 
     override fun isAnException(url: String): Boolean {
-        return if (featureToggle.isFeatureEnabled(PrivacyFeatureName.ContentBlockingFeatureName(), true) == true) {
+        return if (featureToggle.isFeatureEnabled(PrivacyFeatureName.ContentBlockingFeatureName, true) == true) {
             unprotectedTemporary.isAnException(url) || matches(url)
         } else {
             false

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/drm/DrmPlugin.kt

@@ -35,10 +35,10 @@ class DrmPlugin @Inject constructor(
 ) : PrivacyFeaturePlugin {
 
     override fun store(
-        name: String,
+        name: PrivacyFeatureName,
         jsonString: String
     ): Boolean {
-        if (name == featureName.value) {
+        if (name == featureName) {
             val drmExceptions = mutableListOf<DrmExceptionEntity>()
             val moshi = Moshi.Builder().build()
             val jsonAdapter: JsonAdapter<DrmFeature> =
@@ -56,5 +56,5 @@ class DrmPlugin @Inject constructor(
         return false
     }
 
-    override val featureName: PrivacyFeatureName = PrivacyFeatureName.DrmFeatureName()
+    override val featureName: PrivacyFeatureName = PrivacyFeatureName.DrmFeatureName
 }

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/drm/RealDrm.kt

@@ -50,7 +50,7 @@ class RealDrm @Inject constructor(
     }
 
     private fun shouldEnableDrmForUri(uri: Uri): Boolean {
-        val isFeatureEnabled = featureToggle.isFeatureEnabled(PrivacyFeatureName.DrmFeatureName(), defaultValue = true) ?: false
+        val isFeatureEnabled = featureToggle.isFeatureEnabled(PrivacyFeatureName.DrmFeatureName, defaultValue = true)
         return isFeatureEnabled && domainsThatAllowDrm(uri.baseHost)
     }
 

privacy-config/privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/gpc/GpcPlugin.kt

@@ -36,10 +36,10 @@ class GpcPlugin @Inject constructor(
 ) : PrivacyFeaturePlugin {
 
     override fun store(
-        name: String,
+        name: PrivacyFeatureName,
         jsonString: String
     ): Boolean {
-        if (name == featureName.value) {
+        if (name == featureName) {
             val gpcExceptions = mutableListOf<GpcExceptionEntity>()
             val gpcHeaders = mutableListOf<GpcHeaderEnabledSiteEntity>()
             val moshi = Moshi.Builder().build()
@@ -61,5 +61,5 @@ class GpcPlugin @Inject constructor(
         return false
     }
 
-    override val featureName: PrivacyFeatureName = PrivacyFeatureName.GpcFeatureName()
+    override val featureName: PrivacyFeatureName = PrivacyFeatureName.GpcFeatureName
 }