Improve feature toggle API to actually use default value #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
aitorvs
force-pushed
the
feature/aitor/feature_toggle_api
branch
8 times, most recently
from
dc88b59 to
a95ae1b
Compare
aitorvs
force-pushed
the
feature/aitor/feature_toggle_api
branch
3 times, most recently
from
edee6d8 to
a336430
Compare
aitorvs
force-pushed
the
feature/aitor/feature_toggle_api
branch
from
a336430 to
8fc57a4
Compare
marcosholgado
approved these changes
Mar 23, 2022
...essaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/di/AndroidAppAttrMatcher.kt
Outdated
Show resolved
Hide resolved
...te-messaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/di/DeviceAttrMatcher.kt
Outdated
Show resolved
Hide resolved
...mote-messaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/di/UserAttrMatcher.kt
Outdated
Show resolved
Hide resolved
vpn-internal/src/main/java/com/duckduckgo/vpn/internal/feature/VpnInternalSettingsActivity.kt
Outdated
Show resolved
Hide resolved
...g-store/src/main/java/com/duckduckgo/privacy/config/store/PrivacyFeatureTogglesRepository.kt
Show resolved
Hide resolved
...-toggles-impl/src/test/java/com/duckduckgo/feature/toggles/impl/RealFeatureToggleImplTest.kt
Outdated
Show resolved
Hide resolved
...nfig-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/amplinks/RealAmpLinks.kt
Outdated
Show resolved
Hide resolved
...privacy-config-impl/src/main/java/com/duckduckgo/privacy/config/impl/features/gpc/RealGpc.kt
Outdated
Show resolved
Hide resolved
...in/java/com/duckduckgo/privacy/config/impl/features/trackerallowlist/RealTrackerAllowlist.kt
Outdated
Show resolved
Hide resolved
...ava/com/duckduckgo/privacy/config/impl/features/trackingparameters/RealTrackingParameters.kt
Outdated
Show resolved
Hide resolved
aitorvs
force-pushed
the
feature/aitor/feature_toggle_api
branch
3 times, most recently
from
b823401 to
3e50004
Compare
aitorvs
force-pushed
the
feature/aitor/feature_toggle_api
branch
from
3e50004 to
2a05ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1202001932298291/f
Description
The
FeatureToggleAPI (implementation) currently doesn't make use of thedefaultValuespassed in. This PR improves that by making use of them.It also modifies other semantics:
isFeatureEnabledwould returnnullwhen a feature that didn't exist was passed in as a parameterIllegalArgumentExceptionbut that scenario would mean the develper forgot to actually add the code 🤷Steps to test this PR