Class organisation #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borntocompile
requested review from
FancySensei,
LukeAvery92,
SlaveykoSlaveykov-Dubit,
danhalldubit,
kkjamie and
zieglerkevin
FancySensei
approved these changes
Feb 26, 2019
SlaveykoSlaveykov-Dubit
approved these changes
Feb 26, 2019
kkjamie
approved these changes
Feb 26, 2019
zieglerkevin
approved these changes
Feb 26, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated tests into 3 files all partial class of GameObjectExtensionsTests
E.g:
GameObjectExtensionsTests.cs- Contains Setup and Tear down methodsCreateChildTests.cs- Contains tests against overloaded CreateChild methodsReplaceChildTests.csContains tests against overloaded ReplaceChild methodsSeparated core game object extension methods into partial classes. Same principal as above.
This should make things easier to maintain and expand IHierarchyBehaviour in future.