Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for branch in list commits bb onprem API #215

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

mohitg0795
Copy link
Contributor

@mohitg0795 mohitg0795 commented Aug 11, 2022

@@ -83,9 +83,9 @@ func (s *gitService) ListCommits(ctx context.Context, repo string, opts scm.Comm
namespace, name := scm.Split(repo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitg0795 what happens if there is no opts.ref passed or its an empty string. Does the URL still work ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its empty string, then it shows results of default branch. After your comment, I added an integration test as well for the same.

@tphoney tphoney merged commit 09a4fde into drone:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants