Skip to content

Fix failing pipenv installation on Windows GH actions runners #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jun 8, 2025
Merged

Fix failing pipenv installation on Windows GH actions runners #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
0a63154
use --pre --clear when using pipenv on windows
chrisjkuch May 6, 2025
07506a5
remove typo
chrisjkuch May 6, 2025
27b412a
try clearing lockfile first before installing
chrisjkuch May 6, 2025
82f567a
temporarily bypass pipenv install by using pipenv run pip install - t…
chrisjkuch Jun 4, 2025
8f1113e
linting / formatting
chrisjkuch Jun 4, 2025
24d6f9e
no requirements file, try pipenv install again
chrisjkuch Jun 4, 2025
7ca13c9
try pipenv graph first, also cat pipfile to look at contents
chrisjkuch Jun 4, 2025
1ca4274
try locking with verbose output
chrisjkuch Jun 4, 2025
2b1d58a
try converting to requirements.txt
chrisjkuch Jun 4, 2025
85ebe0b
what happens on other OSes?
chrisjkuch Jun 4, 2025
dd153f9
try including all pipenv search sources
chrisjkuch Jun 4, 2025
beb9377
try end-around again using reuqirements.txt
chrisjkuch Jun 4, 2025
b7609d5
[skip render] make sed command windows-friendly
chrisjkuch Jun 4, 2025
c2f9eb2
[skip render] remove sed, echo individually
chrisjkuch Jun 4, 2025
8b13e68
[skip render] use python -m pipenv install to use conda python
chrisjkuch Jun 4, 2025
e1ba0bd
[skip render] try setting pipenv python environment variable
chrisjkuch Jun 4, 2025
befbb88
[skip render] print path to see if there is a 32 bit python installed
chrisjkuch Jun 4, 2025
db56a71
[skip render] remove run:
chrisjkuch Jun 4, 2025
e29f5ae
[skip render] add checks for pipenv python path and arch
chrisjkuch Jun 4, 2025
3780f64
[skip render] try setting arch of python to 64 bit explicitly
chrisjkuch Jun 4, 2025
e7147f9
[skip render] echo path from pipenv harness to see if theres another …
chrisjkuch Jun 4, 2025
2f0efc5
[skip render] hardcode python path
chrisjkuch Jun 4, 2025
09cfbdb
[skip render] add .exe suffix
chrisjkuch Jun 4, 2025
3116fbb
[skip render] try setting pipenv python path with .exe suffix but sti…
chrisjkuch Jun 4, 2025
8fb1d23
[skip render] try pinning pipenv < 2025
chrisjkuch Jun 4, 2025
8b8ac30
[skip render] unpin pipenv, try creating virtualenv with system python
chrisjkuch Jun 4, 2025
dbd5b44
[skip render] try pipenv install directly instead of pipenv --python
chrisjkuch Jun 4, 2025
1e5c67f
[skip render] add python executable location debugging to pipenv harness
chrisjkuch Jun 4, 2025
54279d1
[skip render] add pythonfinder to dev requirements
chrisjkuch Jun 4, 2025
fa6f27a
[skip render] cut down on execution time, only use pythonfinder
chrisjkuch Jun 4, 2025
2548dce
[skip render] typo
chrisjkuch Jun 4, 2025
992961e
[skip render] try using uv rather than setup-python
chrisjkuch Jun 4, 2025
465f807
[skip render] use different behavior in pipenv harness for windows ru…
chrisjkuch Jun 4, 2025
fac27ae
[skip render] use setup-python
chrisjkuch Jun 4, 2025
484758f
[skip render] fix shell script syntax
chrisjkuch Jun 4, 2025
b27c442
[skip render] fix if block end
chrisjkuch Jun 4, 2025
6f3d600
[skip render] revert temporary changes to debug windows runner
chrisjkuch Jun 4, 2025
d2815a2
[skip render] more reversions
chrisjkuch Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ jobs:
pipenv --version
which virtualenv
virtualenv --version
which python
python --version
python -c "import platform; print(f'Python architecture: {platform.architecture()}')"

- name: Run tests
run: |
Expand Down
10 changes: 9 additions & 1 deletion tests/pipenv_harness.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,15 @@ source $CCDS_ROOT/test_functions.sh
# navigate to the generated project and run make commands
cd $1
make
make create_environment

# GitHub-hosted Windows runners using setup-python have 32-bit versions of Python
# installed (see #452). We can test the make command on non-Windows systems,
# but on Windows we should ensure we use the system python
if [[ "$RUNNER_OS" == "Windows" ]]; then
pipenv --python $(shell where python).exe
else
make create_environment
fi

# can happen outside of environment since pipenv knows based on Pipfile
make requirements
Expand Down
Loading