Fix failing pipenv installation on Windows GH actions runners #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbull
temporarily deployed
to
cjk-pipenv-windows-fix - Cookiecutter Data Science PR #453
Render
Destroyed
…emporarily switch to only running pipenv tests on only windows runners
pjbull
temporarily deployed
to
cjk-pipenv-windows-fix - Cookiecutter Data Science PR #453
Render
Destroyed
chrisjkuch
changed the title
…python we dont know about
…ll using make create environment
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a failing pipenv installation on Windows by explicitly specifying the system Python path for Windows runners while preserving existing behavior on Linux/macOS.
- Adjusts the pipenv harness script to use the system Python on Windows.
- Adds debugging output in the GitHub Actions workflow to log Python details.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/pipenv_harness.sh | Updates the script to detect Windows and specify the system Python. |
| .github/workflows/tests.yml | Adds commands to output Python path, version, and architecture. |
chrisjkuch
changed the title
jayqi
approved these changes
Jun 6, 2025
pjbull
temporarily deployed
to
cjk-pipenv-windows-fix - Cookiecutter Data Science PR #453
Render
Destroyed
chrisjkuch
force-pushed
the
cjk-pipenv-windows-fix
branch
2 times, most recently
from
4c57a9f to
d2815a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #452
Tried lots of things tracking down and attempting to solve this error, which appears to have been introduced with changes to pipenv in 2025.0.0 that vendor changes to pythonfinder. I think the combination of Windows runners + setup-python caching + running on different OSes with different Python versions leads to a situation where there's a 32-bit version of python that gets found and prioritized by pythonfinder, and pipenv has chosen not to enable architecture specification / enforcement.
In the end, I folded and I explicitly specify the actions runner system python path (implicitly used elsewhere) to use for creating the pipenv venv on the Windows runners, while still testing the
make create_environmentcommand on Linux and macOS. Open to other ways of tackling this (e.g., using uv for python setup everywhere which I think would also fix this).