Skip to content

Conversation

baranwalayush
Copy link

  • Added the CONTRIBUTING.md file to better help the new contributors and adhere to the standard coding guidelines.

Copy link
Member

@draeger draeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions for improvement. Thanks for preparing that!

@tyzerrr
Copy link
Collaborator

tyzerrr commented Sep 24, 2025

@baranwalayush Basically, LGTM.
But maybe, this file is a little bit huge size.
CONTRINUTING.md is an entry point for new contributors, so this file should be shortened as much as possible.
This repo, official golang github repo is a great example for you.

@NeumannArthur
Copy link
Collaborator

LGTM

@tyzerrr tyzerrr requested a review from draeger September 27, 2025 02:38
@baranwalayush
Copy link
Author

@tyzerrr Thank you for the suggestion! In the case of Golang, they have a separate webpage for contribution guidelines where they are redirecting from the contributing.md page, which is not true in our case. Besides that, I believe that there is nothing overwhelming in this file and a new contributor can easily read and understand the guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants