fix: make API compatible

src/ProcessManagerBundle/Model/Process/Dao.php

@@ -34,7 +34,7 @@ public function getById($id = null)
             $this->model->setId($id);
         }
 
-        $data = $this->db->fetchRow('SELECT * FROM '.$this->tableName.' WHERE id = ?', [$this->model->getId()]);
+        $data = $this->db->fetchAssociative('SELECT * FROM '.$this->tableName.' WHERE id = ?', [$this->model->getId()]);
 
         if (!$data["id"]) {
             throw new \Exception("Process with the ID " . $this->model->getId() . " doesn't exists");
@@ -100,10 +100,10 @@ public function delete()
     /**
      * @param array $data
      */
-    protected function assignVariablesToModel($data)
+    protected function assignVariablesToModel(array $data): void
     {
         foreach($data as $key => &$value) {
-            if ($key === "artifact") {
+            if ($key === "artifact" && $value !== null) {
                 $value = Asset::getById($value);
             }
         }

src/ProcessManagerBundle/Model/Process/Listing.php

@@ -39,7 +39,7 @@ class Listing extends Model\Listing\AbstractListing implements PaginateListingIn
      *
      * @var array
      */
-    public $data = null;
+    public ?array $data = null;
 
     /**
      * @var string
@@ -53,7 +53,7 @@ class Listing extends Model\Listing\AbstractListing implements PaginateListingIn
      *
      * @return bool
      */
-    public function isValidOrderKey($key)
+    public function isValidOrderKey(string $key): bool
     {
         return in_array($key, $this->validOrderKeys);
     }
@@ -83,7 +83,7 @@ public function setObjects($data)
      *
      * @return mixed
      */
-    public function count()
+    public function count(): int
     {
         return $this->getTotalCount();
     }
@@ -96,7 +96,7 @@ public function count()
      *
      * @return mixed
      */
-    public function getItems($offset, $itemCountPerPage)
+    public function getItems(int $offset, int $itemCountPerPage): array
     {
         $this->setOffset($offset);
         $this->setLimit($itemCountPerPage);
@@ -141,7 +141,7 @@ public function getLocale()
     /**
      * Rewind.
      */
-    public function rewind()
+    public function rewind(): void
     {
         $this->getData();
         reset($this->data);
@@ -152,7 +152,7 @@ public function rewind()
      *
      * @return mixed
      */
-    public function current()
+    public function current(): mixed
     {
         $this->getData();
         $var = current($this->data);
@@ -165,7 +165,7 @@ public function current()
      *
      * @return mixed
      */
-    public function key()
+    public function key(): string|int|null
     {
         $this->getData();
         $var = key($this->data);
@@ -178,20 +178,18 @@ public function key()
      *
      * @return mixed
      */
-    public function next()
+    public function next(): void
     {
         $this->getData();
-        $var = next($this->data);
-
-        return $var;
+        next($this->data);
     }
 
     /**
      * valid.
      *
      * @return bool
      */
-    public function valid()
+    public function valid(): bool
     {
         $this->getData();
         $var = $this->current() !== false;

src/ProcessManagerBundle/Model/Process/Listing/Dao.php

@@ -56,7 +56,7 @@ public function getQueryBuilder($addListingParameters = true, ...$columns): Doct
      *
      * @return ProcessInterface[]
      */
-    public function load()
+    public function load(): array
     {
         // load id's
         $list = $this->loadIdList();
@@ -82,7 +82,7 @@ public function load()
     public function loadIdList()
     {
         $queryBuilder = $this->getQueryBuilder(true, [sprintf('%s as id', $this->getTableName() . '.id')]);
-        $objectIds = $this->db->fetchCol((string) $queryBuilder, $this->model->getConditionVariables(), $this->model->getConditionVariableTypes());
+        $objectIds = $this->db->fetchFirstColumn((string) $queryBuilder, $this->model->getConditionVariables(), $this->model->getConditionVariableTypes());
 
         return array_map('intval', $objectIds);
     }
@@ -112,7 +112,7 @@ public function getCount()
      *
      * @throws \Exception
      */
-    public function getTotalCount()
+    public function getTotalCount(): int
     {
         $queryBuilder = $this->getQueryBuilder(false, 'id');
         return $queryBuilder->execute()->rowCount();