Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pimcore 11 compat #94

Merged
merged 11 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: make API compatible
  • Loading branch information
dkarlovi committed Sep 21, 2023
commit cb08c87f3bc2bdfa6b180ce952041bfb45928bd9
9 changes: 1 addition & 8 deletions src/ProcessManagerBundle/Controller/ExecutableController.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,9 @@

class ExecutableController extends ResourceController
{
private array $configTypes = [];

public function setConfigTypes(array $configTypes): void
{
$this->configTypes = $configTypes;
}

public function getConfigAction(Request $request): JsonResponse
{
$types = $this->configTypes;
$types = $this->parameterBag->get('process_manager.processes');

return $this->viewHandler->handle([
'types' => array_keys($types)
Expand Down
4 changes: 2 additions & 2 deletions src/ProcessManagerBundle/Controller/ProcessController.php
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ public function stopAction(Request $request): JsonResponse
public function clearAction(Request $request): JsonResponse
{
$seconds = (int)$request->get('seconds', 604_800);
$logDirectory = $this->container->getParameter('process_manager.log_directory');
$keepLogs = $this->container->getParameter('process_manager.keep_logs');
$logDirectory = $this->parameterBag->get('process_manager.log_directory');
$keepLogs = $this->parameterBag->get('process_manager.keep_logs');

/** @var CleanupService $cleanupService */
$cleanupService = $this->container->get(CleanupService::class);
Expand Down

This file was deleted.