fix: align useCombobox getToggleButtonProps type with useSelect #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useCombobox's getToggleButtonProps was only compatible with HTMLButtonElement useSelect is compatible with any HTMLElement
drewbrend
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1738 1738
Branches 522 522
=========================================
Hits 1738 1738 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Allow comboboxes to have a toggle button of any element type in TypeScript (not just an HTMLButtonElement)
Why:
useCombobox's getToggleButtonProps was only compatible with HTMLButtonElement
useSelect is compatible with any HTMLElement
This is related to my previous PR: #1486
I am now upgrading our repo to downshift V8 and noticed that this is fixed for selects, however comboboxes are still locked to using a button by this type.
How:
I simply changed HTMLButtonElement to HTMLElement to match select's behaviour.
I am not familiar enough with these types to say for sure, but it seems like we could simply align UseSelectGetToggleButtonPropsOptions with this UseComboboxGetToggleButtonPropsOptions? The only difference after this PR is that
UseComboboxGetToggleButtonPropsOptionsalso has adisabledprop (through GetToggleButtonPropsOptions). Are implementations usinguseSelectable to disable the toggle button? If so, I think these could be simplified to use a shared type.Checklist: