fix: change getToggleButtonProps typing to support div #1486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
getToggleButtonProps
should support HTMLButtonElement or HTMLDivElement propsWhy:
In the downshift docs,
useSelect
recommends applyinggetToggleButtonProps
to a div element butgetToggleButtonProps
specifies itsoptions
are specific to a button. This works fine, unless you want to provide options togetToggleButtonProps
that are unique to a div element, in my case I ran into this when providing aref
to my HTMLDivElement - this conflicted becauseRef<HTMLDivElement>
is not applicable toRef<HTMLButtonElement>
How:
Simply added
| HTMLDivElement
to its type.Checklist: