Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing potential undefined #88

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fixing potential undefined #88

merged 2 commits into from
Oct 25, 2019

Conversation

danielcherubini
Copy link
Contributor

@danielcherubini danielcherubini commented Oct 24, 2019 •
edited
Loading

Related to issue
#87

This solves an issue where a S3 Bucket name wasn't existing..

dougmoscrop
dougmoscrop approved these changes Oct 24, 2019
View reviewed changes
Copy link
Owner

@dougmoscrop dougmoscrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple test would be nice!

@danielcherubini
Copy link
Contributor Author

danielcherubini commented Oct 24, 2019 via email

@dougmoscrop dougmoscrop merged commit fb2e854 into dougmoscrop:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougmoscrop dougmoscrop dougmoscrop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielcherubini @dougmoscrop