Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-info - Cannot read property 'toLowerCase' of undefined #87

Open
danielcherubini opened this issue Oct 24, 2019 · 3 comments
Open

aws-info - Cannot read property 'toLowerCase' of undefined #87

danielcherubini opened this issue Oct 24, 2019 · 3 comments

Comments

@danielcherubini
Copy link
Contributor

Hi.

In line 33 of deployment-bucket-endpoint.js if the bucket doesn't reply with a region, it sets the region as undefined. Making the second pass on aws-info throw an error Cannot read property 'toLowerCase' of undefined

const { region = provider.region } = this.options;

@danielcherubini
Copy link
Contributor Author

Digging deeper, when we used curl we got the region, when we used node https we didn't get it.. I'm going to make a fix and open a PR

@dougmoscrop
Copy link
Owner

Thanks - being defensive is always a good idea, but I'd like to make sure we're not misusing the S3 API - your comment above makes me think we might need to spoof a user agent or something?

@danielcherubini
Copy link
Contributor Author

That I don't know, but it felt like it was related to a bucket that might not have existed at the time, so amazon replied with incomplete data..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants